Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am being asked for passphrase unexpectedly and can't exit the dialog loop #22416

Closed
kittykat opened this issue Jun 1, 2022 · 4 comments · Fixed by matrix-org/matrix-js-sdk#2430
Closed

I am being asked for passphrase unexpectedly and can't exit the dialog loop #22416

kittykat opened this issue Jun 1, 2022 · 4 comments · Fixed by matrix-org/matrix-js-sdk#2430
Assignees
@duxovni
Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Release-Blocker Z-Rageshake Has attached rageshake (not for log submission process)

Comments

@kittykat
Copy link
Contributor

kittykat commented Jun 1, 2022

Steps to reproduce

  1. Use Element web for a while, then close tab
  2. Open a new tab, see the Security Key dialog pop up:

Screenshot from 2022-06-01 16-00-13

-> I don't think I should be presented with this dialog right now?

  1. Click "Go Back" because that seems to be the non-destructive exit path, see the cancel dialog:

Screenshot from 2022-06-01 16-00-39element

  1. Click "Cancel" to confirm that I want to exit the flow as I can see decrypted messages in the background.
  2. Get returned to the previous dialog

Outcome

What did you expect?

Continue using the app without having to think about encryption

What happened instead?

I got stuck in a loop. Clicking outside the two dialogs keeps in going round in a loop. Pressing X doesn't close the dialog. Continue is greyed out but looks clickable when I hover over it.

I can't get to the composer or settings to get the app version or do a rageshake.

Operating system

No response

Browser information

Chromium 101.0.4951.64 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@uhoreg uhoreg added S-Critical Prevents work, causes data loss and/or has no workaround A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 1, 2022
@uhoreg
Copy link
Member

uhoreg commented Jun 1, 2022

For reference, you can send a rageshake by opening the JavaScript console and entering mxSendRageshake("rageshake for #22416")

@clokep
Copy link

clokep commented Jun 2, 2022

I also saw this and sent a rageshake. Will backlink!

@robintown robintown added the Z-Rageshake Has attached rageshake (not for log submission process) label Jun 2, 2022
@uhoreg uhoreg added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 2, 2022
@uhoreg
Copy link
Member

uhoreg commented Jun 2, 2022

Since several other people are reporting this, I'm upgrading it from O-Uncommon to O-Occasional.

@turt2live
Copy link
Member

likely cause: matrix-org/matrix-js-sdk#2373

flagging as release blocker for next RC, not upcoming release.

@duxovni duxovni mentioned this issue Jun 2, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jul 7, 2022
@su-ex
Merge tag 'v19.0.0' into sc
2a6db46 
* Remove unused sessionStore ([\matrix-org#2455](matrix-org#2455)).
* Implement MSC3827: Filtering of `/publicRooms` by room type ([\matrix-org#2469](matrix-org#2469)).
* expose latestLocationEvent on beacon model ([\matrix-org#2467](matrix-org#2467)). Contributed by @kerryarchibald.
* Live location share - add start time leniency ([\matrix-org#2465](matrix-org#2465)). Contributed by @kerryarchibald.
* Log real errors and not just their messages, traces are useful ([\matrix-org#2464](matrix-org#2464)).
* Various changes to `src/crypto` files for correctness ([\matrix-org#2137](matrix-org#2137)). Contributed by @ShadowJonathan.
* Update MSC3786 implementation: Check the `state_key` ([\matrix-org#2429](matrix-org#2429)).
* Timeline needs to refresh when we see a MSC2716 marker event  ([\matrix-org#2299](matrix-org#2299)). Contributed by @MadLittleMods.
* Try to load keys from key backup when a message fails to decrypt ([\matrix-org#2373](matrix-org#2373)). Fixes element-hq/element-web#21026. Contributed by @duxovni.
* Send call version `1` as a string ([\matrix-org#2471](matrix-org#2471)). Fixes element-hq/element-web#22629.
* Fix issue with `getEventTimeline` returning undefined for thread roots in main timeline ([\matrix-org#2454](matrix-org#2454)). Fixes element-hq/element-web#22539.
* Add missing `type` property on `IAuthData` ([\matrix-org#2463](matrix-org#2463)).
* Clearly indicate that `lastReply` on a Thread can return falsy ([\matrix-org#2462](matrix-org#2462)).
* Fix issues with getEventTimeline and thread roots ([\matrix-org#2444](matrix-org#2444)). Fixes element-hq/element-web#21613.
* Live location sharing - monitor liveness of beacons yet to start ([\matrix-org#2437](matrix-org#2437)). Contributed by @kerryarchibald.
* Refactor Relations to not be per-EventTimelineSet ([\matrix-org#2412](matrix-org#2412)). Fixes matrix-org#2399 and element-hq/element-web#22298.
* Add tests for sendEvent threadId handling ([\matrix-org#2435](matrix-org#2435)). Fixes element-hq/element-web#22433.
* Make sure `encryptAndSendKeysToDevices` assumes devices are unique per-user. ([\matrix-org#2136](matrix-org#2136)). Fixes matrix-org#2135. Contributed by @ShadowJonathan.
* Don't bug the user while re-checking key backups after decryption failures ([\matrix-org#2430](matrix-org#2430)). Fixes element-hq/element-web#22416. Contributed by @duxovni.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duxovni duxovni

Labels
A-E2EE-Cross-Signing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Release-Blocker Z-Rageshake Has attached rageshake (not for log submission process)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't bug the user while re-checking key backups after decryption failures matrix-org/matrix-js-sdk
6 participants
@kittykat @clokep @uhoreg @turt2live @duxovni @robintown