Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location share in thread after a message creates a reply #22433

Closed
weeman1337 opened this issue Jun 3, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2435
Closed

Location share in thread after a message creates a reply #22433

weeman1337 opened this issue Jun 3, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2435
Assignees
@t3chguy
Labels
A-Location-Sharing A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
Web App Team

Comments

@weeman1337
Copy link
Contributor

Steps to reproduce

  1. Sign into threads beta
  2. Create a thread
  3. Post a message
  4. Share your location

Outcome

What did you expect?

Location shared

What happened instead?

Location shared as reply

thread_location

Operating system

Ubuntu 22.04 LTS

Browser information

Firefox 100.0.2 (64-bit)

URL for webapp

https://develop.element.io/

Application version

Version von Element: 76c9535-react-3174cf2606b4-js-518e16e6d545 Version von Olm: 3.2.8

Homeserver

No response

Will you send logs?

No
@weeman1337 weeman1337 added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads A-Location-Sharing labels Jun 3, 2022
@github-actions github-actions bot added the Z-Labs label Jun 3, 2022
@t3chguy t3chguy self-assigned this Jun 6, 2022
@t3chguy t3chguy added this to Ready in Web App Team via automation Jun 6, 2022
@t3chguy t3chguy moved this from Ready to In Progress in Web App Team Jun 6, 2022
@t3chguy t3chguy moved this from In Progress to In Review in Web App Team Jun 6, 2022
@t3chguy t3chguy mentioned this issue Jun 6, 2022
Merged
Web App Team automation moved this from In Review to Done Jun 7, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jul 7, 2022
@su-ex
Merge tag 'v19.0.0' into sc
2a6db46 
* Remove unused sessionStore ([\matrix-org#2455](matrix-org#2455)).
* Implement MSC3827: Filtering of `/publicRooms` by room type ([\matrix-org#2469](matrix-org#2469)).
* expose latestLocationEvent on beacon model ([\matrix-org#2467](matrix-org#2467)). Contributed by @kerryarchibald.
* Live location share - add start time leniency ([\matrix-org#2465](matrix-org#2465)). Contributed by @kerryarchibald.
* Log real errors and not just their messages, traces are useful ([\matrix-org#2464](matrix-org#2464)).
* Various changes to `src/crypto` files for correctness ([\matrix-org#2137](matrix-org#2137)). Contributed by @ShadowJonathan.
* Update MSC3786 implementation: Check the `state_key` ([\matrix-org#2429](matrix-org#2429)).
* Timeline needs to refresh when we see a MSC2716 marker event  ([\matrix-org#2299](matrix-org#2299)). Contributed by @MadLittleMods.
* Try to load keys from key backup when a message fails to decrypt ([\matrix-org#2373](matrix-org#2373)). Fixes element-hq/element-web#21026. Contributed by @duxovni.
* Send call version `1` as a string ([\matrix-org#2471](matrix-org#2471)). Fixes element-hq/element-web#22629.
* Fix issue with `getEventTimeline` returning undefined for thread roots in main timeline ([\matrix-org#2454](matrix-org#2454)). Fixes element-hq/element-web#22539.
* Add missing `type` property on `IAuthData` ([\matrix-org#2463](matrix-org#2463)).
* Clearly indicate that `lastReply` on a Thread can return falsy ([\matrix-org#2462](matrix-org#2462)).
* Fix issues with getEventTimeline and thread roots ([\matrix-org#2444](matrix-org#2444)). Fixes element-hq/element-web#21613.
* Live location sharing - monitor liveness of beacons yet to start ([\matrix-org#2437](matrix-org#2437)). Contributed by @kerryarchibald.
* Refactor Relations to not be per-EventTimelineSet ([\matrix-org#2412](matrix-org#2412)). Fixes matrix-org#2399 and element-hq/element-web#22298.
* Add tests for sendEvent threadId handling ([\matrix-org#2435](matrix-org#2435)). Fixes element-hq/element-web#22433.
* Make sure `encryptAndSendKeysToDevices` assumes devices are unique per-user. ([\matrix-org#2136](matrix-org#2136)). Fixes matrix-org#2135. Contributed by @ShadowJonathan.
* Don't bug the user while re-checking key backups after decryption failures ([\matrix-org#2430](matrix-org#2430)). Fixes element-hq/element-web#22416. Contributed by @duxovni.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Location-Sharing A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
No open projects
Web App Team
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for sendEvent threadId handling matrix-org/matrix-js-sdk
2 participants
@t3chguy @weeman1337