Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned threads on Element Nightly stopped working #22539

Closed
alexmehandzhiyska opened this issue Jun 11, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2454
Closed

Pinned threads on Element Nightly stopped working #22539

alexmehandzhiyska opened this issue Jun 11, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2454
Assignees
@t3chguy
Labels
A-Message-Pinning A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
Web App Team

Comments

@alexmehandzhiyska
Copy link

Steps to reproduce

  1. I open a chat with a friend on Element Nightly
  2. I click on the "Pinned messages" icon at the top menu of the chat room
  3. I click on a pinned thread I would like to open

Outcome

What did you expect?

I expected to be able to read all of the messages in the pinned thread I have selected

What happened instead?

I got the following error: "Tried to load a specific point in this room's timeline, but was unable to find it." My friend tried opening it as well and got the same error.

image

Operating system

macOS

Application version

Element Nightly Version 2022061001

How did you install the app?

https://element.io/get-started#nightly

Homeserver

matrix.org

Will you send logs?

No
@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Message-Pinning A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 12, 2022
@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed Z-Labs labels Jun 12, 2022
@t3chguy t3chguy mentioned this issue Jun 13, 2022
Merged
@t3chguy t3chguy self-assigned this Jun 13, 2022
@RiotRobot RiotRobot added this to Ready in Web App Team Jun 13, 2022
@t3chguy t3chguy moved this from Ready to In Progress in Web App Team Jun 13, 2022
@t3chguy t3chguy mentioned this issue Jun 13, 2022
Merged
@t3chguy t3chguy moved this from In Progress to In Review in Web App Team Jun 13, 2022
Web App Team automation moved this from In Review to Done Jun 15, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jul 7, 2022
@su-ex
Merge tag 'v19.0.0' into sc
2a6db46 
* Remove unused sessionStore ([\matrix-org#2455](matrix-org#2455)).
* Implement MSC3827: Filtering of `/publicRooms` by room type ([\matrix-org#2469](matrix-org#2469)).
* expose latestLocationEvent on beacon model ([\matrix-org#2467](matrix-org#2467)). Contributed by @kerryarchibald.
* Live location share - add start time leniency ([\matrix-org#2465](matrix-org#2465)). Contributed by @kerryarchibald.
* Log real errors and not just their messages, traces are useful ([\matrix-org#2464](matrix-org#2464)).
* Various changes to `src/crypto` files for correctness ([\matrix-org#2137](matrix-org#2137)). Contributed by @ShadowJonathan.
* Update MSC3786 implementation: Check the `state_key` ([\matrix-org#2429](matrix-org#2429)).
* Timeline needs to refresh when we see a MSC2716 marker event  ([\matrix-org#2299](matrix-org#2299)). Contributed by @MadLittleMods.
* Try to load keys from key backup when a message fails to decrypt ([\matrix-org#2373](matrix-org#2373)). Fixes element-hq/element-web#21026. Contributed by @duxovni.
* Send call version `1` as a string ([\matrix-org#2471](matrix-org#2471)). Fixes element-hq/element-web#22629.
* Fix issue with `getEventTimeline` returning undefined for thread roots in main timeline ([\matrix-org#2454](matrix-org#2454)). Fixes element-hq/element-web#22539.
* Add missing `type` property on `IAuthData` ([\matrix-org#2463](matrix-org#2463)).
* Clearly indicate that `lastReply` on a Thread can return falsy ([\matrix-org#2462](matrix-org#2462)).
* Fix issues with getEventTimeline and thread roots ([\matrix-org#2444](matrix-org#2444)). Fixes element-hq/element-web#21613.
* Live location sharing - monitor liveness of beacons yet to start ([\matrix-org#2437](matrix-org#2437)). Contributed by @kerryarchibald.
* Refactor Relations to not be per-EventTimelineSet ([\matrix-org#2412](matrix-org#2412)). Fixes matrix-org#2399 and element-hq/element-web#22298.
* Add tests for sendEvent threadId handling ([\matrix-org#2435](matrix-org#2435)). Fixes element-hq/element-web#22433.
* Make sure `encryptAndSendKeysToDevices` assumes devices are unique per-user. ([\matrix-org#2136](matrix-org#2136)). Fixes matrix-org#2135. Contributed by @ShadowJonathan.
* Don't bug the user while re-checking key backups after decryption failures ([\matrix-org#2430](matrix-org#2430)). Fixes element-hq/element-web#22416. Contributed by @duxovni.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Message-Pinning A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
No open projects
Web App Team
Done
Milestone
No milestone
3 participants
@t3chguy @SimonBrandner @alexmehandzhiyska