Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread includes messages from main timeline #21613

Closed
andybalaam opened this issue Mar 31, 2022 · 6 comments · Fixed by matrix-org/matrix-js-sdk#2444
Closed

Thread includes messages from main timeline #21613

andybalaam opened this issue Mar 31, 2022 · 6 comments · Fixed by matrix-org/matrix-js-sdk#2444
Assignees
@t3chguy
Labels
A-Room-View A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
Web App Team

Comments

@andybalaam
Copy link
Contributor

Steps to reproduce

  1. Chatting in a room
  2. One participant started a thread based on one of the messages
  3. More chatting

Outcome

What did you expect?

Only messages sent to the thread should be included in the thread.

What happened instead?

Messages from before the thread were included:

image

The thread started with Travis' "slight bump" message, but messages from before that are visible in the thread.

Operating system

Ubuntu 21.10

Browser information

Firefox 98.0.2

URL for webapp

https://develop.element.io

Application version

Element version: f029b68-react-d09205122d14-js-4360ae7ff817 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

Yes
@germain-gg germain-gg mentioned this issue Mar 31, 2022
Merged
@germain-gg germain-gg added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-View O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads labels Mar 31, 2022
@Stebalien
Copy link

I ran into this issue once, but it disappeared after I restarted Element. In case it's relevant, the thread started with a reply to a message in another thread.

I.e.:

  1. Message A:
    1. Threaded: Message B
    2. Threaded: Message C
  2. Message D, reply to C.
    1. Message E

@novocaine
Copy link
Contributor

I believe this hasn't been seen for a while so assume fixed

@t3chguy
Copy link
Member

t3chguy commented Apr 25, 2022

Saw this just now

image

@t3chguy t3chguy reopened this Apr 25, 2022
@t3chguy
Copy link
Member

t3chguy commented May 4, 2022

I had this happen again during development, and it made React devtools very unhappy. From what I could tell, the main timeline things are actually glitched/duplicated by React itself, they don't exist in the shadow DOM under the right panel

@t3chguy t3chguy mentioned this issue May 4, 2022
Merged
MadLittleMods added a commit to matrix-org/matrix-react-sdk that referenced this issue May 5, 2022
@MadLittleMods
Log TimelinePanel debuggin info when opening the bug report modal
2861486 
To debug all of the timeline problems:

 - element-hq/element-web#21613
 - element-hq/element-web#21922
 - element-hq/element-web#21432
 - element-hq/element-web#21533
@MadLittleMods MadLittleMods mentioned this issue May 5, 2022
Merged
MadLittleMods added a commit to matrix-org/matrix-react-sdk that referenced this issue May 10, 2022
@MadLittleMods
Log TimelinePanel debugging info when opening the bug report modal (#…
3a241e0 
…8502)

To debug all of the timeline problems:

 - element-hq/element-web#21613
 - element-hq/element-web#21922
 - element-hq/element-web#21432
 - element-hq/element-web#21533
@MadLittleMods
Copy link
Contributor

MadLittleMods commented May 16, 2022 •
edited

Reproduced this again but this time I think I was able to capture the necessary debugging info that was asked for previously, https://github.com/matrix-org/element-web-rageshakes/issues/12986

The logs include TimelinePanel debugging snapshot info and have ScrollPanel DEBUG_SCROLL and TimelinePanel DEBUG enabled.

The random extra messages showing in the thread, show up in the React devtools and the keys look sane (pictured in the rageshake).

@t3chguy t3chguy mentioned this issue May 18, 2022
Closed
@t3chguy t3chguy assigned t3chguy and unassigned germain-gg May 20, 2022
@t3chguy t3chguy removed the Z-Labs label May 20, 2022
@t3chguy t3chguy added this to In Progress in Web App Team May 20, 2022
@t3chguy t3chguy mentioned this issue May 25, 2022
Merged
@t3chguy t3chguy moved this from In Progress to Blocked in Web App Team May 25, 2022
@t3chguy t3chguy mentioned this issue May 28, 2022
Closed
@robintown robintown mentioned this issue May 28, 2022
Closed
@t3chguy
Copy link
Member

t3chguy commented Jun 1, 2022

Alright so the issue is that the Threads EventTimelineSet somehow grows a second timeline which it shouldn't

@t3chguy t3chguy moved this from Blocked to In Progress in Web App Team Jun 1, 2022
@t3chguy t3chguy moved this from In Progress to In Review in Web App Team Jun 8, 2022
@t3chguy t3chguy mentioned this issue Jun 8, 2022
Merged
Web App Team automation moved this from In Review to Done Jun 8, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jul 7, 2022
@su-ex
Merge tag 'v19.0.0' into sc
2a6db46 
* Remove unused sessionStore ([\matrix-org#2455](matrix-org#2455)).
* Implement MSC3827: Filtering of `/publicRooms` by room type ([\matrix-org#2469](matrix-org#2469)).
* expose latestLocationEvent on beacon model ([\matrix-org#2467](matrix-org#2467)). Contributed by @kerryarchibald.
* Live location share - add start time leniency ([\matrix-org#2465](matrix-org#2465)). Contributed by @kerryarchibald.
* Log real errors and not just their messages, traces are useful ([\matrix-org#2464](matrix-org#2464)).
* Various changes to `src/crypto` files for correctness ([\matrix-org#2137](matrix-org#2137)). Contributed by @ShadowJonathan.
* Update MSC3786 implementation: Check the `state_key` ([\matrix-org#2429](matrix-org#2429)).
* Timeline needs to refresh when we see a MSC2716 marker event  ([\matrix-org#2299](matrix-org#2299)). Contributed by @MadLittleMods.
* Try to load keys from key backup when a message fails to decrypt ([\matrix-org#2373](matrix-org#2373)). Fixes element-hq/element-web#21026. Contributed by @duxovni.
* Send call version `1` as a string ([\matrix-org#2471](matrix-org#2471)). Fixes element-hq/element-web#22629.
* Fix issue with `getEventTimeline` returning undefined for thread roots in main timeline ([\matrix-org#2454](matrix-org#2454)). Fixes element-hq/element-web#22539.
* Add missing `type` property on `IAuthData` ([\matrix-org#2463](matrix-org#2463)).
* Clearly indicate that `lastReply` on a Thread can return falsy ([\matrix-org#2462](matrix-org#2462)).
* Fix issues with getEventTimeline and thread roots ([\matrix-org#2444](matrix-org#2444)). Fixes element-hq/element-web#21613.
* Live location sharing - monitor liveness of beacons yet to start ([\matrix-org#2437](matrix-org#2437)). Contributed by @kerryarchibald.
* Refactor Relations to not be per-EventTimelineSet ([\matrix-org#2412](matrix-org#2412)). Fixes matrix-org#2399 and element-hq/element-web#22298.
* Add tests for sendEvent threadId handling ([\matrix-org#2435](matrix-org#2435)). Fixes element-hq/element-web#22433.
* Make sure `encryptAndSendKeysToDevices` assumes devices are unique per-user. ([\matrix-org#2136](matrix-org#2136)). Fixes matrix-org#2135. Contributed by @ShadowJonathan.
* Don't bug the user while re-checking key backups after decryption failures ([\matrix-org#2430](matrix-org#2430)). Fixes element-hq/element-web#22416. Contributed by @duxovni.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Room-View A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
No open projects
Web App Team
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with getEventTimeline and thread roots matrix-org/matrix-js-sdk
6 participants
@novocaine @andybalaam @Stebalien @MadLittleMods @germain-gg @t3chguy