Cancellable search requests #498
Assignees
Labels
A-Timeline-Search
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Major
Severely degrades major functionality or product features, with no satisfactory workaround
T-Enhancement
Projects
Milestone
Comments
|
As far as I can tell, this is largely implemented:
|
|
Yes this seems to be fixed |
|
the issue says to cancel the underlying js-sdk request, given we recently discarded bluebird and that wasn't used for cancellations then I doubt it actually gets cancelled |
|
@t3chguy I can't reproduce this (seems to be cancelable), can you confirm that this is an ongoing issue? |
|
Just because the UI looks cancelled, doesn't mean the API request is. |
SimonBrandner
added
O-Occasional
kittykat
added
the
S-Major
su-ex
added a commit
to SchildiChat/element-desktop
that referenced
this issue
Dec 6, 2022
* Update to Electron 21 ([\element-hq#458](element-hq#458)). Fixes element-hq/element-web#23783. * Further improve replies ([\#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq/element-web#19074, element-hq/element-web#18194 element-hq/element-web#18027 and element-hq/element-web#19179. * Enable users to join group calls from multiple devices ([\#9625](matrix-org/matrix-react-sdk#9625)). * fix(visual): make cursor a pointer for summaries ([\#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91. * Add placeholder for rich text editor ([\#9613](matrix-org/matrix-react-sdk#9613)). * Consolidate public room search experience ([\#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq/element-web#22846. * New password reset flow ([\#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq/element-web#23131. * Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)). * sliding sync: add lazy-loading member support ([\#9530](matrix-org/matrix-react-sdk#9530)). * Limit formatting bar offset to top of composer ([\#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq/element-web#12359. Contributed by @owi92. * Fix issues around up arrow event edit shortcut ([\#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq/element-web#18497 and element-hq/element-web#18964. * Fix search not being cleared when clicking on a result ([\#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq/element-web#23845. * Fix screensharing in 1:1 calls ([\#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq/element-web#23808. * Fix the background color flashing when joining a call ([\#9640](matrix-org/matrix-react-sdk#9640)). * Fix the size of the 'Private space' icon ([\#9638](matrix-org/matrix-react-sdk#9638)). * Fix reply editing in rich text editor (https ([\#9615](matrix-org/matrix-react-sdk#9615)). * Fix thread list jumping back down while scrolling ([\#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq/element-web#23727. * Fix regression with TimelinePanel props updates not taking effect ([\#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq/element-web#23794. * Fix form tooltip positioning ([\#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq/element-web#22861. * Extract Search handling from RoomView into its own Component ([\#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq/element-web#498. * Fix call splitbrains when switching between rooms ([\#9692](matrix-org/matrix-react-sdk#9692)).
su-ex
added a commit
to SchildiChat/element-web
that referenced
this issue
Dec 6, 2022
* Further improve replies ([\element-hq#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq#19074, element-hq#18194 element-hq#18027 and element-hq#19179. * Enable users to join group calls from multiple devices ([\element-hq#9625](matrix-org/matrix-react-sdk#9625)). * fix(visual): make cursor a pointer for summaries ([\element-hq#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91. * Add placeholder for rich text editor ([\element-hq#9613](matrix-org/matrix-react-sdk#9613)). * Consolidate public room search experience ([\element-hq#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq#22846. * New password reset flow ([\element-hq#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq#23131. * Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)). * sliding sync: add lazy-loading member support ([\element-hq#9530](matrix-org/matrix-react-sdk#9530)). * Limit formatting bar offset to top of composer ([\element-hq#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq#12359. Contributed by @owi92. * Fix issues around up arrow event edit shortcut ([\element-hq#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq#18497 and element-hq#18964. * Fix search not being cleared when clicking on a result ([\element-hq#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq#23845. * Fix screensharing in 1:1 calls ([\element-hq#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq#23808. * Fix the background color flashing when joining a call ([\element-hq#9640](matrix-org/matrix-react-sdk#9640)). * Fix the size of the 'Private space' icon ([\element-hq#9638](matrix-org/matrix-react-sdk#9638)). * Fix reply editing in rich text editor (https ([\element-hq#9615](matrix-org/matrix-react-sdk#9615)). * Fix thread list jumping back down while scrolling ([\element-hq#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq#23727. * Fix regression with TimelinePanel props updates not taking effect ([\element-hq#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq#23794. * Fix form tooltip positioning ([\element-hq#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq#22861. * Extract Search handling from RoomView into its own Component ([\element-hq#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq#498. * Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)). * [Backport staging] Fix replies to emotes not showing as inline ([\element-hq#9708](matrix-org/matrix-react-sdk#9708)).
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this issue
Dec 6, 2022
* Further improve replies ([\matrix-org#6396](matrix-org#6396)). Fixes element-hq/element-web#19074, element-hq/element-web#18194 element-hq/element-web#18027 and element-hq/element-web#19179. * Enable users to join group calls from multiple devices ([\matrix-org#9625](matrix-org#9625)). * fix(visual): make cursor a pointer for summaries ([\matrix-org#9419](matrix-org#9419)). Contributed by @r00ster91. * Add placeholder for rich text editor ([\matrix-org#9613](matrix-org#9613)). * Consolidate public room search experience ([\matrix-org#9605](matrix-org#9605)). Fixes element-hq/element-web#22846. * New password reset flow ([\matrix-org#9581](matrix-org#9581)). Fixes element-hq/element-web#23131. * Device manager - add tooltip to device details toggle ([\matrix-org#9594](matrix-org#9594)). * sliding sync: add lazy-loading member support ([\matrix-org#9530](matrix-org#9530)). * Limit formatting bar offset to top of composer ([\matrix-org#9365](matrix-org#9365)). Fixes element-hq/element-web#12359. Contributed by @owi92. * Fix issues around up arrow event edit shortcut ([\matrix-org#9645](matrix-org#9645)). Fixes element-hq/element-web#18497 and element-hq/element-web#18964. * Fix search not being cleared when clicking on a result ([\matrix-org#9635](matrix-org#9635)). Fixes element-hq/element-web#23845. * Fix screensharing in 1:1 calls ([\matrix-org#9612](matrix-org#9612)). Fixes element-hq/element-web#23808. * Fix the background color flashing when joining a call ([\matrix-org#9640](matrix-org#9640)). * Fix the size of the 'Private space' icon ([\matrix-org#9638](matrix-org#9638)). * Fix reply editing in rich text editor (https ([\matrix-org#9615](matrix-org#9615)). * Fix thread list jumping back down while scrolling ([\matrix-org#9606](matrix-org#9606)). Fixes element-hq/element-web#23727. * Fix regression with TimelinePanel props updates not taking effect ([\matrix-org#9608](matrix-org#9608)). Fixes element-hq/element-web#23794. * Fix form tooltip positioning ([\matrix-org#9598](matrix-org#9598)). Fixes element-hq/element-web#22861. * Extract Search handling from RoomView into its own Component ([\matrix-org#9574](matrix-org#9574)). Fixes element-hq/element-web#498. * Fix call splitbrains when switching between rooms ([\matrix-org#9692](matrix-org#9692)). * Fix replies to emotes not showing as inline ([\matrix-org#9707](matrix-org#9707)). Fixes element-hq/element-web#23903.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Search requests can take a long time. We need to be able to cancel the JS SDK promise - either using something like bluebird cancellable promises, or extending the JS SDK to have a cancelSearch method a bit like the cancelUpload method.
The text was updated successfully, but these errors were encountered: