Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions: Undo a reaction #9574

Closed
jryans opened this issue Apr 26, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#2954
Closed

Reactions: Undo a reaction #9574

jryans opened this issue Apr 26, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#2954
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 26, 2019 •
edited
Loading

Undo a reaction by clicking an emoji type below the message you previously voted for.

To send an undo to the HS, redact the previous reaction event.
This was referenced Apr 29, 2019
Closed
Closed
@jryans jryans self-assigned this May 9, 2019
@jryans jryans added this to In Progress in Web App Team via automation May 9, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 10, 2019
@jryans
Update relation collections after redaction
54f2ff6 
This watches for redactions of relations and updates the relations collection
to match, including various aggregations. In addition, a redaction event is
emitted on the redaction collection to notify consumers of the change.

Part of element-hq/element-web#9574
Part of element-hq/element-web#9485
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 10, 2019
@jryans
Update reactions when redacted
6a59143 
This updates the reaction state in the reaction row and action bar when a
reaction is redacted.

Part of element-hq/element-web#9574
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue May 10, 2019
@jryans
Send and redact reaction events
dc4fccd 
This updates both the reaction row and action bar UIs to send and redact
reaction events as appropriate based on user interactions.

Fixes element-hq/element-web#9574
Fixes element-hq/element-web#9572
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 10, 2019
@jryans
Update relation collections after redaction
4c8321d 
This watches for redactions of relations and updates the relations collection
to match, including various aggregations. In addition, a redaction event is
emitted on the redaction collection to notify consumers of the change.

Part of element-hq/element-web#9574
Part of element-hq/element-web#9485
This was referenced May 10, 2019
Merged
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team May 10, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue May 13, 2019
@jryans
Update relation collections after redaction
53d8cf0 
This watches for redactions of relations and updates the relations collection
to match, including various aggregations. In addition, a redaction event is
emitted on the redaction collection to notify consumers of the change.

Part of element-hq/element-web#9574
Part of element-hq/element-web#9485
Web App Team automation moved this from In Review to In Test May 13, 2019
@jryans jryans moved this from In Test to Done in Web App Team May 30, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v1.11.16' into sc
58d68a5 
* Further improve replies ([\element-hq#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq#19074, element-hq#18194 element-hq#18027 and element-hq#19179.
* Enable users to join group calls from multiple devices ([\element-hq#9625](matrix-org/matrix-react-sdk#9625)).
* fix(visual): make cursor a pointer for summaries ([\element-hq#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91.
* Add placeholder for rich text editor ([\element-hq#9613](matrix-org/matrix-react-sdk#9613)).
* Consolidate public room search experience ([\element-hq#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq#22846.
* New password reset flow ([\element-hq#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq#23131.
* Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)).
* sliding sync: add lazy-loading member support ([\element-hq#9530](matrix-org/matrix-react-sdk#9530)).
* Limit formatting bar offset to top of composer ([\element-hq#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq#12359. Contributed by @owi92.
* Fix issues around up arrow event edit shortcut ([\element-hq#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq#18497 and element-hq#18964.
* Fix search not being cleared when clicking on a result ([\element-hq#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq#23845.
* Fix screensharing in 1:1 calls ([\element-hq#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq#23808.
* Fix the background color flashing when joining a call ([\element-hq#9640](matrix-org/matrix-react-sdk#9640)).
* Fix the size of the 'Private space' icon ([\element-hq#9638](matrix-org/matrix-react-sdk#9638)).
* Fix reply editing in rich text editor (https ([\element-hq#9615](matrix-org/matrix-react-sdk#9615)).
* Fix thread list jumping back down while scrolling ([\element-hq#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq#23727.
* Fix regression with TimelinePanel props updates not taking effect ([\element-hq#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq#23794.
* Fix form tooltip positioning ([\element-hq#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq#22861.
* Extract Search handling from RoomView into its own Component ([\element-hq#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq#498.
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* [Backport staging] Fix replies to emotes not showing as inline ([\element-hq#9708](matrix-org/matrix-react-sdk#9708)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send and undo reaction events matrix-org/matrix-react-sdk
2 participants
@jryans @lampholder