Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file upload preview needs to be retina aware #9530

Open
ara4n opened this issue Apr 19, 2019 · 4 comments
Open

file upload preview needs to be retina aware #9530

ara4n opened this issue Apr 19, 2019 · 4 comments
Labels
A-File-Upload Attachments and file uploads A-Media good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ O-Occasional Affects or can be seen by some users regularly or most users rarely T-Defect Z-Platform-Specific

Comments

@ara4n
Copy link
Member

ara4n commented Apr 19, 2019

No description provided.

@lampholder lampholder added T-Defect A-File-Upload Attachments and file uploads labels Apr 24, 2019
@lampholder
Copy link
Member

What are the consequences of its not being retina aware?

@lampholder lampholder added the P2 label Apr 24, 2019
@lampholder
Copy link
Member

(feel free to p2->p1 if the consequences are bad)

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 27, 2021
@ara4n ara4n removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Aug 14, 2021
@ara4n
Copy link
Member Author

ara4n commented Aug 14, 2021

If you upload a hi-dpi image (e.g. a macOS screenshot), then the image preview is shown at 2x physical size, rather than the correct 1x physical size (but 2x resolution). The timeline then gets this right... but then the lightbox gets this wrong (c.f. #18496).

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Platform-Specific A-Media and removed P2 labels Aug 15, 2021
@HarHarLinks
Copy link

related #18198

@t3chguy t3chguy added good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ labels Oct 12, 2022
su-ex added a commit to SchildiChat/element-web that referenced this issue Dec 6, 2022
* Further improve replies ([\element-hq#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq#19074, element-hq#18194 element-hq#18027 and element-hq#19179.
* Enable users to join group calls from multiple devices ([\element-hq#9625](matrix-org/matrix-react-sdk#9625)).
* fix(visual): make cursor a pointer for summaries ([\element-hq#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91.
* Add placeholder for rich text editor ([\element-hq#9613](matrix-org/matrix-react-sdk#9613)).
* Consolidate public room search experience ([\element-hq#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq#22846.
* New password reset flow ([\element-hq#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq#23131.
* Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)).
* sliding sync: add lazy-loading member support ([\element-hq#9530](matrix-org/matrix-react-sdk#9530)).
* Limit formatting bar offset to top of composer ([\element-hq#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq#12359. Contributed by @owi92.
* Fix issues around up arrow event edit shortcut ([\element-hq#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq#18497 and element-hq#18964.
* Fix search not being cleared when clicking on a result ([\element-hq#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq#23845.
* Fix screensharing in 1:1 calls ([\element-hq#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq#23808.
* Fix the background color flashing when joining a call ([\element-hq#9640](matrix-org/matrix-react-sdk#9640)).
* Fix the size of the 'Private space' icon ([\element-hq#9638](matrix-org/matrix-react-sdk#9638)).
* Fix reply editing in rich text editor (https ([\element-hq#9615](matrix-org/matrix-react-sdk#9615)).
* Fix thread list jumping back down while scrolling ([\element-hq#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq#23727.
* Fix regression with TimelinePanel props updates not taking effect ([\element-hq#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq#23794.
* Fix form tooltip positioning ([\element-hq#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq#22861.
* Extract Search handling from RoomView into its own Component ([\element-hq#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq#498.
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* [Backport staging] Fix replies to emotes not showing as inline ([\element-hq#9708](matrix-org/matrix-react-sdk#9708)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-File-Upload Attachments and file uploads A-Media good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ O-Occasional Affects or can be seen by some users regularly or most users rarely T-Defect Z-Platform-Specific
Projects
None yet
Development

No branches or pull requests

5 participants