Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a Docker image for develop #9606

Closed
turt2live opened this issue May 1, 2019 · 0 comments · Fixed by #9736
Closed

Support a Docker image for develop #9606

turt2live opened this issue May 1, 2019 · 0 comments · Fixed by #9736
Labels
A-Packaging Packaging, signing, releasing P2 T-Enhancement T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

We now have a Docker image autobuilding for releases and master, but don't have one for develop. There's a couple ways we can build this:

  • Fix our release process to ensure that matrix-react-sdk and matrix-js-sdk get added to the package.json (and yarn lockfile) as develop, then enable autobuilds in Docker Hub.
  • Set up a Buildkite job to build/publish the image for us, using build args.
  • Use multiple Dockerfiles which change the build arguments, resulting in double the maintenance effort.

Ideally we'd just use build arguments in Docker Hub, however that is not supported: docker/hub-feedback#508
@turt2live turt2live added T-Task Tasks for the team like planning P2 T-Enhancement labels May 1, 2019
@turt2live turt2live changed the title Support a Dockerfile for develop Support a Docker image for develop May 1, 2019
@nim65s nim65s mentioned this issue May 8, 2019
Closed
This was referenced May 13, 2019
Closed
Merged
@jryans jryans added the A-Packaging Packaging, signing, releasing label Jul 29, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v1.11.16' into sc
58d68a5 
* Further improve replies ([\element-hq#6396](matrix-org/matrix-react-sdk#6396)). Fixes element-hq#19074, element-hq#18194 element-hq#18027 and element-hq#19179.
* Enable users to join group calls from multiple devices ([\element-hq#9625](matrix-org/matrix-react-sdk#9625)).
* fix(visual): make cursor a pointer for summaries ([\element-hq#9419](matrix-org/matrix-react-sdk#9419)). Contributed by @r00ster91.
* Add placeholder for rich text editor ([\element-hq#9613](matrix-org/matrix-react-sdk#9613)).
* Consolidate public room search experience ([\element-hq#9605](matrix-org/matrix-react-sdk#9605)). Fixes element-hq#22846.
* New password reset flow ([\element-hq#9581](matrix-org/matrix-react-sdk#9581)). Fixes element-hq#23131.
* Device manager - add tooltip to device details toggle ([\#9594](matrix-org/matrix-react-sdk#9594)).
* sliding sync: add lazy-loading member support ([\element-hq#9530](matrix-org/matrix-react-sdk#9530)).
* Limit formatting bar offset to top of composer ([\element-hq#9365](matrix-org/matrix-react-sdk#9365)). Fixes element-hq#12359. Contributed by @owi92.
* Fix issues around up arrow event edit shortcut ([\element-hq#9645](matrix-org/matrix-react-sdk#9645)). Fixes element-hq#18497 and element-hq#18964.
* Fix search not being cleared when clicking on a result ([\element-hq#9635](matrix-org/matrix-react-sdk#9635)). Fixes element-hq#23845.
* Fix screensharing in 1:1 calls ([\element-hq#9612](matrix-org/matrix-react-sdk#9612)). Fixes element-hq#23808.
* Fix the background color flashing when joining a call ([\element-hq#9640](matrix-org/matrix-react-sdk#9640)).
* Fix the size of the 'Private space' icon ([\element-hq#9638](matrix-org/matrix-react-sdk#9638)).
* Fix reply editing in rich text editor (https ([\element-hq#9615](matrix-org/matrix-react-sdk#9615)).
* Fix thread list jumping back down while scrolling ([\element-hq#9606](matrix-org/matrix-react-sdk#9606)). Fixes element-hq#23727.
* Fix regression with TimelinePanel props updates not taking effect ([\element-hq#9608](matrix-org/matrix-react-sdk#9608)). Fixes element-hq#23794.
* Fix form tooltip positioning ([\element-hq#9598](matrix-org/matrix-react-sdk#9598)). Fixes element-hq#22861.
* Extract Search handling from RoomView into its own Component ([\element-hq#9574](matrix-org/matrix-react-sdk#9574)). Fixes element-hq#498.
* Fix call splitbrains when switching between rooms ([\element-hq#9692](matrix-org/matrix-react-sdk#9692)).
* [Backport staging] Fix replies to emotes not showing as inline ([\element-hq#9708](matrix-org/matrix-react-sdk#9708)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Packaging Packaging, signing, releasing P2 T-Enhancement T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Dockerfile work for develop and other branches element-hq/element-web
2 participants
@jryans @turt2live