Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPEs in BaseAvatar breaking everything when joining rooms #8483

Closed
ara4n opened this issue Feb 8, 2019 · 3 comments
Closed

NPEs in BaseAvatar breaking everything when joining rooms #8483

ara4n opened this issue Feb 8, 2019 · 3 comments
Labels
P1 T-Defect X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Feb 8, 2019

This is reproduceable whenever i join an IRC portal room on develop, and breaks the world.

RVS update: !VgqLmaArcYmcJRFTsY:localhost #irc_#matthewtest2:localhost loading? false joining? true initial? true shouldPeek? true
19:49:19.849 rageshake.js:61 Warning: Failed prop type: The prop `name` is marked as required in `BaseAvatar`, but its value is `undefined`.
    in BaseAvatar (created by RoomAvatar)
    in RoomAvatar (created by RoomHeader)
    in div (created by RoomHeader)
    in div (created by RoomHeader)
    in div (created by RoomHeader)
    in RoomHeader (created by RoomView)
    in div (created by RoomView)
    in RoomView (created by LoggedInView)
    in div (created by LoggedInView)
    in DragDropContext (created by LoggedInView)
    in div (created by LoggedInView)
    in LoggedInView (created by MatrixChat)
    in MatrixChat
consoleObj.(anonymous function) @ rageshake.js:61
printWarning @ warning.js:35
warning @ warning.js:59
checkReactTypeSpec @ checkReactTypeSpec.js:80
validatePropTypes @ ReactElementValidator.js:162
createElement @ ReactElementValidator.js:216
RoomAvatar_render @ RoomAvatar.js:160
(anonymous) @ ReactCompositeComponent.js:795
measureLifeCyclePerf @ ReactCompositeComponent.js:75
_renderValidatedComponentWithoutOwnerOrContext @ ReactCompositeComponent.js:794
_renderValidatedComponent @ ReactCompositeComponent.js:821
performInitialMount @ ReactCompositeComponent.js:360
mountComponent @ ReactCompositeComponent.js:256
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
performInitialMount @ ReactCompositeComponent.js:370
mountComponent @ ReactCompositeComponent.js:256
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
performInitialMount @ ReactCompositeComponent.js:370
mountComponent @ ReactCompositeComponent.js:256
mountComponent @ ReactReconciler.js:45
updateChildren @ ReactChildReconciler.js:121
_reconcilerUpdateChildren @ ReactMultiChild.js:206
_updateChildren @ ReactMultiChild.js:310
updateChildren @ ReactMultiChild.js:296
_updateDOMChildren @ ReactDOMComponent.js:946
updateComponent @ ReactDOMComponent.js:760
receiveComponent @ ReactDOMComponent.js:721
receiveComponent @ ReactReconciler.js:124
_updateRenderedComponent @ ReactCompositeComponent.js:753
_performComponentUpdate @ ReactCompositeComponent.js:723
updateComponent @ ReactCompositeComponent.js:644
receiveComponent @ ReactCompositeComponent.js:545
receiveComponent @ ReactReconciler.js:124
updateChildren @ ReactChildReconciler.js:109
_reconcilerUpdateChildren @ ReactMultiChild.js:206
_updateChildren @ ReactMultiChild.js:310
updateChildren @ ReactMultiChild.js:296
_updateDOMChildren @ ReactDOMComponent.js:946
updateComponent @ ReactDOMComponent.js:760
receiveComponent @ ReactDOMComponent.js:721
receiveComponent @ ReactReconciler.js:124
_updateRenderedComponent @ ReactCompositeComponent.js:753
_performComponentUpdate @ ReactCompositeComponent.js:723
updateComponent @ ReactCompositeComponent.js:644
receiveComponent @ ReactCompositeComponent.js:545
receiveComponent @ ReactReconciler.js:124
_updateRenderedComponent @ ReactCompositeComponent.js:753
_performComponentUpdate @ ReactCompositeComponent.js:723
updateComponent @ ReactCompositeComponent.js:644
performUpdateIfNecessary @ ReactCompositeComponent.js:560
performUpdateIfNecessary @ ReactReconciler.js:156
runBatchedUpdates @ ReactUpdates.js:150
perform @ Transaction.js:143
perform @ Transaction.js:143
perform @ ReactUpdates.js:89
flushBatchedUpdates @ ReactUpdates.js:172
closeAll @ Transaction.js:209
perform @ Transaction.js:156
batchedUpdates @ ReactDefaultBatchingStrategy.js:62
enqueueUpdate @ ReactUpdates.js:200
enqueueUpdate @ ReactUpdateQueue.js:23
enqueueSetState @ ReactUpdateQueue.js:217
./node_modules/react/lib/ReactBaseClasses.js.ReactComponent.setState @ ReactBaseClasses.js:64
(anonymous) @ MatrixChat.js:96
tryCatcher @ bluebird.js:5278
Promise._settlePromiseFromHandler @ bluebird.js:3299
Promise._settlePromise @ bluebird.js:3356
Promise._settlePromiseCtx @ bluebird.js:3392
(anonymous) @ bluebird.js:167
Promise.then (async)
schedule @ bluebird.js:4506
Async.invoke @ bluebird.js:166
Promise._then @ bluebird.js:3048
Promise.done @ bluebird.js:2917
_viewRoom @ MatrixChat.js:853
onAction @ MatrixChat.js:561
_invokeCallback @ Dispatcher.js:200
dispatch @ Dispatcher.js:176
setTimeout (async)
dispatch @ dispatcher.js:52
(anonymous) @ RoomViewStore.js:177
tryCatcher @ bluebird.js:5276
Promise._settlePromiseFromHandler @ bluebird.js:3297
Promise._settlePromise @ bluebird.js:3354
Promise._fulfillPromises @ bluebird.js:3454
Promise._settlePromises @ bluebird.js:3480
(anonymous) @ bluebird.js:175
Promise.then (async)
schedule @ bluebird.js:4504
Async.settlePromises @ bluebird.js:174
Promise._fulfill @ bluebird.js:3425
Promise._resolveCallback @ bluebird.js:3217
deferResolve @ bluebird.js:3496
(anonymous) @ http-api.js:850
(anonymous) @ http-api.js:775
on_end @ index.js:294
on_state_change @ index.js:244
XMLHttpRequest.send (async)
run_xhr @ index.js:218
request @ index.js:179
(anonymous) @ browser-index.js:13
_request @ http-api.js:749
requestOtherUrl @ http-api.js:625
request @ http-api.js:510
authedRequest @ http-api.js:453
../matrix-js-sdk/lib/base-apis.js.MatrixBaseApis.getRoomIdForAlias @ base-apis.js:1068
_viewRoom @ RoomViewStore.js:175
__onDispatch @ RoomViewStore.js:78
__invokeOnDispatch @ FluxStore.js:150
(anonymous) @ FluxStore.js:81
_invokeCallback @ Dispatcher.js:200
dispatch @ Dispatcher.js:176
setTimeout (async)
dispatch @ dispatcher.js:52
runFn @ SlashCommands.js:228
run @ SlashCommands.js:51
processCommandInput @ SlashCommands.js:648
handleReturn @ MessageComposerInput.js:1082
onKeyDown @ MessageComposerInput.js:748
editorPlugin.(anonymous function) @ slate-react.es.js:4353
run @ slate.es.js:7847
(anonymous) @ slate-react.es.js:4321
call @ slate.es.js:10716
change @ slate-react.es.js:4275
onEvent @ slate-react.es.js:4320
obj.(anonymous function) @ slate-react.es.js:4259
onEvent @ slate-react.es.js:2077
obj.(anonymous function) @ slate-react.es.js:1777
boundFunc @ ReactErrorUtils.js:65
./node_modules/react-dom/lib/ReactErrorUtils.js.ReactErrorUtils.invokeGuardedCallback @ ReactErrorUtils.js:71
executeDispatch @ EventPluginUtils.js:85
executeDispatchesInOrder @ EventPluginUtils.js:108
executeDispatchesAndRelease @ EventPluginHub.js:43
executeDispatchesAndReleaseTopLevel @ EventPluginHub.js:53
forEachAccumulated @ forEachAccumulated.js:24
processEventQueue @ EventPluginHub.js:254
runEventQueueInBatch @ ReactEventEmitterMixin.js:16
handleTopLevel @ ReactEventEmitterMixin.js:27
handleTopLevelImpl @ ReactEventListener.js:72
perform @ Transaction.js:143
batchedUpdates @ ReactDefaultBatchingStrategy.js:62
batchedUpdates @ ReactUpdates.js:96
dispatchEvent @ ReactEventListener.js:147
19:49:19.853 Avatar.js:58 Uncaught TypeError: Cannot read property 'length' of undefined
    at Object.defaultAvatarUrlForString (http://localhost:8080/bundles/_dev_/bundle.js:51316:31)
    at Object._getState (http://localhost:8080/bundles/_dev_/bundle.js:88720:48)
    at Object.getInitialState (http://localhost:8080/bundles/_dev_/bundle.js:88662:21)
    at new <anonymous> (http://localhost:8080/bundles/_dev_/bundle.js:314047:54)
    at http://localhost:8080/bundles/_dev_/bundle.js:339166:18
    at measureLifeCyclePerf (http://localhost:8080/bundles/_dev_/bundle.js:338947:12)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (http://localhost:8080/bundles/_dev_/bundle.js:339165:16)
    at ReactCompositeComponentWrapper._constructComponent (http://localhost:8080/bundles/_dev_/bundle.js:339156:19)
    at ReactCompositeComponentWrapper.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:339059:21)
    at Object.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:346319:35)
    at ReactCompositeComponentWrapper.performInitialMount (http://localhost:8080/bundles/_dev_/bundle.js:339242:34)
    at ReactCompositeComponentWrapper.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:339129:21)
    at Object.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:346319:35)
    at ReactDOMComponent.mountChildren (http://localhost:8080/bundles/_dev_/bundle.js:345154:44)
    at ReactDOMComponent._createInitialChildren (http://localhost:8080/bundles/_dev_/bundle.js:340602:32)
    at ReactDOMComponent.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:340421:12)
    at Object.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:346319:35)
    at ReactDOMComponent.mountChildren (http://localhost:8080/bundles/_dev_/bundle.js:345154:44)
    at ReactDOMComponent._createInitialChildren (http://localhost:8080/bundles/_dev_/bundle.js:340602:32)
    at ReactDOMComponent.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:340421:12)
    at Object.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:346319:35)
    at ReactDOMComponent.mountChildren (http://localhost:8080/bundles/_dev_/bundle.js:345154:44)
    at ReactDOMComponent._createInitialChildren (http://localhost:8080/bundles/_dev_/bundle.js:340602:32)
    at ReactDOMComponent.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:340421:12)
    at Object.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:346319:35)
    at ReactCompositeComponentWrapper.performInitialMount (http://localhost:8080/bundles/_dev_/bundle.js:339242:34)
    at ReactCompositeComponentWrapper.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:339129:21)
    at Object.mountComponent (http://localhost:8080/bundles/_dev_/bundle.js:346319:35)
From previous event:
    at Object._viewRoom (http://localhost:8080/bundles/_dev_/bundle.js:73886:17)
    at Object.onAction (http://localhost:8080/bundles/_dev_/bundle.js:73605:22)
    at MatrixDispatcher._invokeCallback (http://localhost:8080/bundles/_dev_/bundle.js:169946:24)
    at MatrixDispatcher.dispatch (http://localhost:8080/bundles/_dev_/bundle.js:169922:14)
defaultAvatarUrlForString @ Avatar.js:58
_getState @ BaseAvatar.js:118
BaseAvatar_getInitialState @ BaseAvatar.js:25
BaseAvatar @ factory.js:839
(anonymous) @ ReactCompositeComponent.js:294
measureLifeCyclePerf @ ReactCompositeComponent.js:75
_constructComponentWithoutOwner @ ReactCompositeComponent.js:293
_constructComponent @ ReactCompositeComponent.js:284
mountComponent @ ReactCompositeComponent.js:186
mountComponent @ ReactReconciler.js:45
performInitialMount @ ReactCompositeComponent.js:370
mountComponent @ ReactCompositeComponent.js:256
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
performInitialMount @ ReactCompositeComponent.js:370
mountComponent @ ReactCompositeComponent.js:256
mountComponent @ ReactReconciler.js:45
mountChildren @ ReactMultiChild.js:236
_createInitialChildren @ ReactDOMComponent.js:703
mountComponent @ ReactDOMComponent.js:522
mountComponent @ ReactReconciler.js:45
performInitialMount @ ReactCompositeComponent.js:370
mountComponent @ ReactCompositeComponent.js:256
mountComponent @ ReactReconciler.js:45
updateChildren @ ReactChildReconciler.js:121
_reconcilerUpdateChildren @ ReactMultiChild.js:206
_updateChildren @ ReactMultiChild.js:310
updateChildren @ ReactMultiChild.js:296
_updateDOMChildren @ ReactDOMComponent.js:946
updateComponent @ ReactDOMComponent.js:760
receiveComponent @ ReactDOMComponent.js:721
receiveComponent @ ReactReconciler.js:124
_updateRenderedComponent @ ReactCompositeComponent.js:753
_performComponentUpdate @ ReactCompositeComponent.js:723
updateComponent @ ReactCompositeComponent.js:644
receiveComponent @ ReactCompositeComponent.js:545
receiveComponent @ ReactReconciler.js:124
updateChildren @ ReactChildReconciler.js:109
_reconcilerUpdateChildren @ ReactMultiChild.js:206
_updateChildren @ ReactMultiChild.js:310
updateChildren @ ReactMultiChild.js:296
_updateDOMChildren @ ReactDOMComponent.js:946
updateComponent @ ReactDOMComponent.js:760
receiveComponent @ ReactDOMComponent.js:721
receiveComponent @ ReactReconciler.js:124
_updateRenderedComponent @ ReactCompositeComponent.js:753
_performComponentUpdate @ ReactCompositeComponent.js:723
updateComponent @ ReactCompositeComponent.js:644
receiveComponent @ ReactCompositeComponent.js:545
receiveComponent @ ReactReconciler.js:124
_updateRenderedComponent @ ReactCompositeComponent.js:753
_performComponentUpdate @ ReactCompositeComponent.js:723
updateComponent @ ReactCompositeComponent.js:644
performUpdateIfNecessary @ ReactCompositeComponent.js:560
performUpdateIfNecessary @ ReactReconciler.js:156
runBatchedUpdates @ ReactUpdates.js:150
perform @ Transaction.js:143
perform @ Transaction.js:143
perform @ ReactUpdates.js:89
flushBatchedUpdates @ ReactUpdates.js:172
closeAll @ Transaction.js:209
perform @ Transaction.js:156
batchedUpdates @ ReactDefaultBatchingStrategy.js:62
enqueueUpdate @ ReactUpdates.js:200
enqueueUpdate @ ReactUpdateQueue.js:23
enqueueSetState @ ReactUpdateQueue.js:217
./node_modules/react/lib/ReactBaseClasses.js.ReactComponent.setState @ ReactBaseClasses.js:64
(anonymous) @ MatrixChat.js:96
tryCatcher @ bluebird.js:5278
Promise._settlePromiseFromHandler @ bluebird.js:3299
Promise._settlePromise @ bluebird.js:3356
Promise._settlePromiseCtx @ bluebird.js:3392
(anonymous) @ bluebird.js:167
setTimeout (async)
Async.throwLater @ bluebird.js:118
Async.fatalError @ bluebird.js:108
Promise._reject @ bluebird.js:3439
Promise._rejectCallback @ bluebird.js:3260
Promise._settlePromiseFromHandler @ bluebird.js:3308
Promise._settlePromise @ bluebird.js:3356
Promise._settlePromiseCtx @ bluebird.js:3392
(anonymous) @ bluebird.js:167
Promise.then (async)
schedule @ bluebird.js:4506
Async.invoke @ bluebird.js:166
Promise._then @ bluebird.js:3048
Promise.done @ bluebird.js:2917
_viewRoom @ MatrixChat.js:853
onAction @ MatrixChat.js:561
_invokeCallback @ Dispatcher.js:200
dispatch @ Dispatcher.js:176
setTimeout (async)
dispatch @ dispatcher.js:52
(anonymous) @ RoomViewStore.js:177
tryCatcher @ bluebird.js:5276
Promise._settlePromiseFromHandler @ bluebird.js:3297
Promise._settlePromise @ bluebird.js:3354
Promise._fulfillPromises @ bluebird.js:3454
Promise._settlePromises @ bluebird.js:3480
(anonymous) @ bluebird.js:175
Promise.then (async)
schedule @ bluebird.js:4504
Async.settlePromises @ bluebird.js:174
Promise._fulfill @ bluebird.js:3425
Promise._resolveCallback @ bluebird.js:3217
deferResolve @ bluebird.js:3496
(anonymous) @ http-api.js:850
(anonymous) @ http-api.js:775
on_end @ index.js:294
on_state_change @ index.js:244
XMLHttpRequest.send (async)
run_xhr @ index.js:218
request @ index.js:179
(anonymous) @ browser-index.js:13
_request @ http-api.js:749
requestOtherUrl @ http-api.js:625
request @ http-api.js:510
authedRequest @ http-api.js:453
../matrix-js-sdk/lib/base-apis.js.MatrixBaseApis.getRoomIdForAlias @ base-apis.js:1068
_viewRoom @ RoomViewStore.js:175
__onDispatch @ RoomViewStore.js:78
__invokeOnDispatch @ FluxStore.js:150
(anonymous) @ FluxStore.js:81
_invokeCallback @ Dispatcher.js:200
dispatch @ Dispatcher.js:176
setTimeout (async)
dispatch @ dispatcher.js:52
runFn @ SlashCommands.js:228
run @ SlashCommands.js:51
processCommandInput @ SlashCommands.js:648
handleReturn @ MessageComposerInput.js:1082
onKeyDown @ MessageComposerInput.js:748
editorPlugin.(anonymous function) @ slate-react.es.js:4353
run @ slate.es.js:7847
(anonymous) @ slate-react.es.js:4321
call @ slate.es.js:10716
change @ slate-react.es.js:4275
onEvent @ slate-react.es.js:4320
obj.(anonymous function) @ slate-react.es.js:4259
onEvent @ slate-react.es.js:2077
obj.(anonymous function) @ slate-react.es.js:1777
boundFunc @ ReactErrorUtils.js:65
./node_modules/react-dom/lib/ReactErrorUtils.js.ReactErrorUtils.invokeGuardedCallback @ ReactErrorUtils.js:71
executeDispatch @ EventPluginUtils.js:85
executeDispatchesInOrder @ EventPluginUtils.js:108
executeDispatchesAndRelease @ EventPluginHub.js:43
executeDispatchesAndReleaseTopLevel @ EventPluginHub.js:53
forEachAccumulated @ forEachAccumulated.js:24
processEventQueue @ EventPluginHub.js:254
runEventQueueInBatch @ ReactEventEmitterMixin.js:16
handleTopLevel @ ReactEventEmitterMixin.js:27
handleTopLevelImpl @ ReactEventListener.js:72
perform @ Transaction.js:143
batchedUpdates @ ReactDefaultBatchingStrategy.js:62
batchedUpdates @ ReactUpdates.js:96
dispatchEvent @ ReactEventListener.js:147
19:49:20.053 rageshake.js:61 Caught /sync error Invariant Violation: Attempted to update component `BaseAvatar` that has already been unmounted (or failed to mount).
    at invariant (http://localhost:8080/bundles/_dev_/bundle.js:317646:15)
    at ReactCompositeComponentWrapper.updateComponent (http://localhost:8080/bundles/_dev_/bundle.js:339455:52)
    at ReactCompositeComponentWrapper.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:339418:10)
    at Object.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:346398:22)
    at ReactCompositeComponentWrapper._updateRenderedComponent (http://localhost:8080/bundles/_dev_/bundle.js:339625:23)
    at ReactCompositeComponentWrapper._performComponentUpdate (http://localhost:8080/bundles/_dev_/bundle.js:339595:10)
    at ReactCompositeComponentWrapper.updateComponent (http://localhost:8080/bundles/_dev_/bundle.js:339516:12)
    at ReactCompositeComponentWrapper.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:339418:10)
    at Object.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:346398:22)
    at Object.updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:338731:25)
    at ReactDOMComponent._reconcilerUpdateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345124:32)
    at ReactDOMComponent._updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345228:31)
    at ReactDOMComponent.updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345215:12)
    at ReactDOMComponent._updateDOMChildren (http://localhost:8080/bundles/_dev_/bundle.js:340845:12)
    at ReactDOMComponent.updateComponent (http://localhost:8080/bundles/_dev_/bundle.js:340659:10)
    at ReactDOMComponent.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:340621:10)
    at Object.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:346398:22)
    at Object.updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:338731:25)
    at ReactDOMComponent._reconcilerUpdateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345124:32)
    at ReactDOMComponent._updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345228:31)
    at ReactDOMComponent.updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345215:12)
    at ReactDOMComponent._updateDOMChildren (http://localhost:8080/bundles/_dev_/bundle.js:340845:12)
    at ReactDOMComponent.updateComponent (http://localhost:8080/bundles/_dev_/bundle.js:340659:10)
    at ReactDOMComponent.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:340621:10)
    at Object.receiveComponent (http://localhost:8080/bundles/_dev_/bundle.js:346398:22)
    at Object.updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:338731:25)
    at ReactDOMComponent._reconcilerUpdateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345124:32)
    at ReactDOMComponent._updateChildren (http://localhost:8080/bundles/_dev_/bundle.js:345228:31)
From previous event:
    at http://localhost:8080/bundles/_dev_/bundle.js:34749:46
From previous event:
    at SyncApi._callee10$ (http://localhost:8080/bundles/_dev_/bundle.js:34548:74)
    at tryCatch (http://localhost:8080/bundles/_dev_/bundle.js:49757:40)
    at Generator.invoke [as _invoke] (http://localhost:8080/bundles/_dev_/bundle.js:49991:22)
    at Generator.prototype.(anonymous function) [as next] (http://localhost:8080/bundles/_dev_/bundle.js:49809:21)
From previous event:
    at SyncApi._processSyncResponse (http://localhost:8080/bundles/_dev_/bundle.js:34837:22)
    at SyncApi._callee7$ (http://localhost:8080/bundles/_dev_/bundle.js:34185:60)
    at tryCatch (http://localhost:8080/bundles/_dev_/bundle.js:49757:40)
    at Generator.invoke [as _invoke] (http://localhost:8080/bundles/_dev_/bundle.js:49991:22)
    at Generator.prototype.(anonymous function) [as next] (http://localhost:8080/bundles/_dev_/bundle.js:49809:21)
@ara4n
Copy link
Member Author

ara4n commented Feb 10, 2019

i am reproducing this reliably when I try to join an IRC-bridged room (using local HS and irc bridge). The flow is:

  • /join #irc_#foo:localhost
  • watch infinite spinner; room never joins
  • hit refresh
  • joins okay. type things into the room - they instantly disappear from the timeline; log fills with the error above
  • hit refresh again
  • now it works :/

@bwindels
Copy link
Contributor

odd, I would have thought matrix-org/matrix-react-sdk#2601 would have fixed this.

@jryans jryans added this to Not Started in Web App Team Feb 11, 2019
@ara4n
Copy link
Member Author

ara4n commented Feb 11, 2019

yup, looks like this is fixed now.

@ara4n ara4n closed this as completed Feb 11, 2019
@jryans jryans removed this from Not Started in Web App Team Feb 13, 2019
su-ex added a commit to SchildiChat/element-web that referenced this issue May 28, 2022
@su-ex
Merge tag 'v1.10.13' into sc
359bd71 
* Go to space landing page when clicking on a selected space ([\element-hq#6442](matrix-org/matrix-react-sdk#6442)). Fixes element-hq#20296.
* Fall back to untranslated string rather than showing missing translation error ([\element-hq#8609](matrix-org/matrix-react-sdk#8609)).
* Show file name and size on images on hover ([\element-hq#6511](matrix-org/matrix-react-sdk#6511)). Fixes element-hq#18197.
* Iterate on search results for message bubbles ([\element-hq#7047](matrix-org/matrix-react-sdk#7047)). Fixes element-hq#20315.
* registration: redesign email verification page ([\element-hq#8554](matrix-org/matrix-react-sdk#8554)). Fixes element-hq#21984.
* Show full thread message in hover title on thread summary ([\element-hq#8568](matrix-org/matrix-react-sdk#8568)). Fixes element-hq#22037.
* Tweak video rooms copy ([\element-hq#8582](matrix-org/matrix-react-sdk#8582)). Fixes element-hq#22176.
* Live location share - beacon tooltip in maximised view ([\element-hq#8572](matrix-org/matrix-react-sdk#8572)).
* Add dialog to navigate long room topics ([\element-hq#8517](matrix-org/matrix-react-sdk#8517)). Fixes element-hq#9623.
* Change spaceroomfacepile tooltip if memberlist is shown ([\element-hq#8571](matrix-org/matrix-react-sdk#8571)). Fixes element-hq#17406.
* Improve message editing UI ([\element-hq#8483](matrix-org/matrix-react-sdk#8483)). Fixes element-hq#9752 and element-hq#22108.
* Make date changes more obvious ([\element-hq#6410](matrix-org/matrix-react-sdk#6410)). Fixes element-hq#16221.
* Enable forwarding static locations ([\element-hq#8553](matrix-org/matrix-react-sdk#8553)).
* Log `TimelinePanel` debugging info when opening the bug report modal ([\element-hq#8502](matrix-org/matrix-react-sdk#8502)).
* Improve welcome screen, add opt-out analytics ([\element-hq#8474](matrix-org/matrix-react-sdk#8474)). Fixes element-hq#21946.
* Converting selected text to MD link when pasting a URL ([\element-hq#8242](matrix-org/matrix-react-sdk#8242)). Fixes element-hq#21634. Contributed by @Sinharitik589.
* Support Inter on custom themes ([\element-hq#8399](matrix-org/matrix-react-sdk#8399)). Fixes element-hq#16293.
* Add a `Copy link` button to the right-click message context-menu labs feature ([\element-hq#8527](matrix-org/matrix-react-sdk#8527)).
* Move widget screenshots labs flag to devtools ([\element-hq#8522](matrix-org/matrix-react-sdk#8522)).
* Remove some labs features which don't get used or create maintenance burden: custom status, multiple integration managers, and do not disturb ([\element-hq#8521](matrix-org/matrix-react-sdk#8521)).
* Add a way to toggle `ScrollPanel` and `TimelinePanel` debug logs ([\element-hq#8513](matrix-org/matrix-react-sdk#8513)).
* Spaces: remove blue beta dot ([\element-hq#8511](matrix-org/matrix-react-sdk#8511)). Fixes element-hq#22061.
* Order new search dialog results by recency ([\element-hq#8444](matrix-org/matrix-react-sdk#8444)).
* Improve pills ([\element-hq#6398](matrix-org/matrix-react-sdk#6398)). Fixes element-hq#16948 and element-hq#21281.
* Add a way to maximize/pin widget from the PiP view ([\element-hq#7672](matrix-org/matrix-react-sdk#7672)). Fixes element-hq#20723.
* Iterate video room designs in labs ([\element-hq#8499](matrix-org/matrix-react-sdk#8499)).
* Improve UI/UX in calls ([\element-hq#7791](matrix-org/matrix-react-sdk#7791)). Fixes element-hq#19937.
* Add ability to change audio and video devices during a call ([\element-hq#7173](matrix-org/matrix-react-sdk#7173)). Fixes element-hq#15595.
* Fix video rooms sometimes connecting muted when they shouldn't ([\element-hq#22125](element-hq#22125)).
* Avoid flashing the 'join conference' button at the user in video rooms ([\element-hq#22120](element-hq#22120)).
* Fully close Jitsi conferences on errors ([\element-hq#22060](element-hq#22060)).
* Fix click behavior of notification badges on spaces ([\element-hq#8627](matrix-org/matrix-react-sdk#8627)). Fixes element-hq#22241.
* Add missing return values in Read Receipt animation code ([\element-hq#8625](matrix-org/matrix-react-sdk#8625)). Fixes element-hq#22175.
* Fix 'continue' button not working after accepting identity server terms of service ([\element-hq#8619](matrix-org/matrix-react-sdk#8619)). Fixes element-hq#20003.
* Proactively fix stuck devices in video rooms ([\element-hq#8587](matrix-org/matrix-react-sdk#8587)). Fixes element-hq#22131.
* Fix position of the message action bar on left side bubbles ([\element-hq#8398](matrix-org/matrix-react-sdk#8398)). Fixes element-hq#21879. Contributed by @luixxiul.
* Fix edge case thread summaries around events without a msgtype ([\element-hq#8576](matrix-org/matrix-react-sdk#8576)).
* Fix favourites metaspace not updating ([\element-hq#8594](matrix-org/matrix-react-sdk#8594)). Fixes element-hq#22156.
* Stop spaces from displaying as rooms in new breadcrumbs ([\element-hq#8595](matrix-org/matrix-react-sdk#8595)). Fixes element-hq#22165.
* Fix avatar position of hidden event on ThreadView ([\element-hq#8592](matrix-org/matrix-react-sdk#8592)). Fixes element-hq#22199. Contributed by @luixxiul.
* Fix MessageTimestamp position next to redacted messages on IRC/modern layout ([\element-hq#8591](matrix-org/matrix-react-sdk#8591)). Fixes element-hq#22181. Contributed by @luixxiul.
* Fix padding of messages in threads ([\element-hq#8574](matrix-org/matrix-react-sdk#8574)). Contributed by @luixxiul.
* Enable overflow of hidden events content ([\element-hq#8585](matrix-org/matrix-react-sdk#8585)). Fixes element-hq#22187. Contributed by @luixxiul.
* Increase composer line height to avoid cutting off emoji ([\element-hq#8583](matrix-org/matrix-react-sdk#8583)). Fixes element-hq#22170.
* Don't consider threads for breaking continuation until actually created ([\element-hq#8581](matrix-org/matrix-react-sdk#8581)). Fixes element-hq#22164.
* Fix displaying hidden events on threads  ([\element-hq#8555](matrix-org/matrix-react-sdk#8555)). Fixes element-hq#22058. Contributed by @luixxiul.
* Fix button width and align 絵文字 (emoji) on the user panel ([\element-hq#8562](matrix-org/matrix-react-sdk#8562)). Fixes element-hq#22142. Contributed by @luixxiul.
* Standardise the margin for settings tabs ([\element-hq#7963](matrix-org/matrix-react-sdk#7963)). Fixes element-hq#20767. Contributed by @yuktea.
* Fix room history not being visible even if we have historical keys ([\element-hq#8563](matrix-org/matrix-react-sdk#8563)). Fixes element-hq#16983.
* Fix oblong avatars in video room lobbies ([\element-hq#8565](matrix-org/matrix-react-sdk#8565)).
* Update thread summary when latest event gets decrypted ([\element-hq#8564](matrix-org/matrix-react-sdk#8564)). Fixes element-hq#22151.
* Fix codepath which can wrongly cause automatic space switch from all rooms ([\element-hq#8560](matrix-org/matrix-react-sdk#8560)). Fixes element-hq#21373.
* Fix effect of URL preview toggle not updating live ([\element-hq#8561](matrix-org/matrix-react-sdk#8561)). Fixes element-hq#22148.
* Fix visual bugs on AccessSecretStorageDialog ([\element-hq#8160](matrix-org/matrix-react-sdk#8160)). Fixes element-hq#19426. Contributed by @luixxiul.
* Fix the width bounce of the clock on the AudioPlayer ([\element-hq#8320](matrix-org/matrix-react-sdk#8320)). Fixes element-hq#21788. Contributed by @luixxiul.
* Hide the verification left stroke only on the thread list ([\element-hq#8525](matrix-org/matrix-react-sdk#8525)). Fixes element-hq#22132. Contributed by @luixxiul.
* Hide recently_viewed dropdown when other modal opens ([\element-hq#8538](matrix-org/matrix-react-sdk#8538)). Contributed by @yaya-usman.
* Only jump to date after pressing the 'go' button ([\element-hq#8548](matrix-org/matrix-react-sdk#8548)). Fixes element-hq#20799.
* Fix download button not working on events that were decrypted too late ([\element-hq#8556](matrix-org/matrix-react-sdk#8556)). Fixes element-hq#19427.
* Align thread summary button with bubble messages on the left side ([\element-hq#8388](matrix-org/matrix-react-sdk#8388)). Fixes element-hq#21873. Contributed by @luixxiul.
* Fix unresponsive notification toggles ([\element-hq#8549](matrix-org/matrix-react-sdk#8549)). Fixes element-hq#22109.
* Set color-scheme property in themes ([\element-hq#8547](matrix-org/matrix-react-sdk#8547)). Fixes element-hq#22124.
* Improve the styling of error messages during search initialization. ([\element-hq#6899](matrix-org/matrix-react-sdk#6899)). Fixes element-hq#19245 and element-hq#18164. Contributed by @KalleStruik.
* Don't leave button tooltips open when closing modals ([\element-hq#8546](matrix-org/matrix-react-sdk#8546)). Fixes element-hq#22121.
* update matrix-analytics-events ([\element-hq#8543](matrix-org/matrix-react-sdk#8543)).
* Handle Jitsi Meet crashes more gracefully ([\element-hq#8541](matrix-org/matrix-react-sdk#8541)).
* Fix regression around pasting links ([\element-hq#8537](matrix-org/matrix-react-sdk#8537)). Fixes element-hq#22117.
* Fixes suggested room not ellipsized on shrinking ([\element-hq#8536](matrix-org/matrix-react-sdk#8536)). Contributed by @yaya-usman.
* Add global spacing between display name and location body ([\element-hq#8523](matrix-org/matrix-react-sdk#8523)). Fixes element-hq#22111. Contributed by @luixxiul.
* Add box-shadow to the reply preview on the main (left) panel only ([\element-hq#8397](matrix-org/matrix-react-sdk#8397)). Fixes element-hq#21894. Contributed by @luixxiul.
* Set line-height: 1 to RedactedBody inside GenericEventListSummary for IRC/modern layout ([\element-hq#8529](matrix-org/matrix-react-sdk#8529)). Fixes element-hq#22112. Contributed by @luixxiul.
* Fix position of timestamp on the chat panel in IRC layout and message edits history modal window ([\element-hq#8464](matrix-org/matrix-react-sdk#8464)). Fixes element-hq#22011 and element-hq#22014. Contributed by @luixxiul.
* Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent ([\element-hq#8485](matrix-org/matrix-react-sdk#8485)). Fixes element-hq#22041. Contributed by @luixxiul.
* Set the same margin to the right side of NewRoomIntro on TimelineCard ([\element-hq#8453](matrix-org/matrix-react-sdk#8453)). Contributed by @luixxiul.
* Remove duplicate tooltip from user pills ([\element-hq#8512](matrix-org/matrix-react-sdk#8512)).
* Set max-width for MLocationBody and MLocationBody_map by default ([\element-hq#8519](matrix-org/matrix-react-sdk#8519)). Fixes element-hq#21983. Contributed by @luixxiul.
* Simplify ReplyPreview UI implementation ([\element-hq#8516](matrix-org/matrix-react-sdk#8516)). Fixes element-hq#22091. Contributed by @luixxiul.
* Fix thread summary overflow on narrow message panel on bubble message layout ([\element-hq#8520](matrix-org/matrix-react-sdk#8520)). Fixes element-hq#22097. Contributed by @luixxiul.
* Live location sharing - refresh beacon timers on tab becoming active ([\element-hq#8515](matrix-org/matrix-react-sdk#8515)).
* Enlarge emoji again ([\element-hq#8509](matrix-org/matrix-react-sdk#8509)). Fixes element-hq#22086.
* Order receipts with the most recent on the right ([\element-hq#8506](matrix-org/matrix-react-sdk#8506)). Fixes element-hq#22044.
* Disconnect from video rooms when leaving ([\element-hq#8500](matrix-org/matrix-react-sdk#8500)).
* Fix soft crash around threads when room isn't yet in store ([\element-hq#8496](matrix-org/matrix-react-sdk#8496)). Fixes element-hq#22047.
* Fix reading of cached room device setting values ([\element-hq#8491](matrix-org/matrix-react-sdk#8491)).
* Add loading spinners to threads panels ([\element-hq#8490](matrix-org/matrix-react-sdk#8490)). Fixes element-hq#21335.
* Fix forwarding UI papercuts ([\element-hq#8482](matrix-org/matrix-react-sdk#8482)). Fixes element-hq#17616.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwindels @ara4n