Dark theme follow up issues

[jryans]

No description provided.

[nadonomy]

Awesome! Small stuff, but:

• E2E icons should use primary/notice colours (fixed in matrix-org/matrix-react-sdk@feb9295)
• Vertical bar splitting top right icons isn't skinned (should we take the primary icon colour and apply 50% opacity?) (fixed in matrix-org/matrix-react-sdk@4409636)
• (+) icons in room list not skinned
• @mention backgrounds not skinned (for now using the room highlight bg would be ok) (fixed in matrix-org/matrix-react-sdk@4227500)
• Adjust gradient to use rgba for Safari (fixed in matrix-org/matrix-react-sdk@5f6907c)
• Change box shadow on top left menu to use bg value (fixed in matrix-org/matrix-react-sdk@f64f39f)
• LLP should be #15171B not #1C1F24 (subtle, but important to establish the same depth hierarchy as the light theme)
• E2E composer decoration, and message hover decoration should use new palette (we're missing a yellow, maybe use the orange if we don't have a yellow when you tackle this)

[jryans]

• Tweak color values to v2 from Nad (fixed in matrix-org/matrix-react-sdk@e09963c)

[aaronraimist]

• Markdown button status appears reversed
  
• Should there be a more visible vertical line here?
  
  
• It would be nice to use a white [m] logo in the room directory
  
• "INVITED" in user list is hard to see (Set h3-color in dark theme matrix-org/matrix-react-sdk#2656)
  
• Room settings that you can't update are hard to read
  
• Safari scrollbars are dark but (one of the) Firefox scrollbars is light. Which is intended? Is Gemini getting killed before 1.0?

[turt2live]

• dialogs don't feel like they have enough of a backdrop on the dark theme · Issue #8584
• no hover effect on messages in new dark theme (fixed in Update dark theme bg-color to show hover effect on messages matrix-org/matrix-react-sdk#2654)

[anoadragon453]

• Dark theme: Impossible to tell difference between sent/not sent messages #8586: Impossible to tell difference between sent/not-sent messages
• Typing indicator on dark theme #8589: Typing indicator on dark theme
• Home screen text is unreadable on dark theme #8603: Home screen text is unreadable on dark theme

[turt2live]

• Pills are hard to read in new dark theme · Issue #8587

[turt2live]

• Widgets blend in with the timeline
  

[nadonomy]

@jryans re widgets blending; they should be using the header/panel background colour

[Half-Shot]

(could people put names next to their issues if possible so I don't have to mouse over all of them?)

[Cadair]

The spinner looks particularly bad on the dark theme I think. It's got a white line around the edges etc.

[Cadair]

• Also, the redacted message bar thing seems much more stark than on the light theme. (fixed in matrix-org/matrix-react-sdk@91c91c5)

[turt2live]

re: redaction bar. There is a dark theme asset from the old design somewhere.

[jryans]

• make dark names more readable when using dark theme · Issue #8611

[jryans]

• Markdown indicator on dark theme is invisible when in RTE mode · Issue #8637

[nadonomy]

• 'back' Chevron in member panel

[turt2live]

• Redaction thingy
• File drop UI (moved to drop & drag target needs to be redesigned for Element #14589)

[turt2live]

• Concerns with color scheme being hard on the eyes

[Half-Shot]

@Cadair #8554 (comment) :)

[turt2live]

• "INVITED" header in member list

[jryans]

• Member search is impossible to read on dark theme and has no clear button

[jryans]

• visibility labels on roomdirectory need to be designed and inverted on dark theme

[jryans]

• Distinguishing rooms with new events is hard in the dark theme

[anoadragon453]

• Code Scrollbars in dark theme are invisible

[SilverWolf32]

Spinners should definitely be inverted to match the background. I don't know if this is OS X-specific, but on here it looks awful.

[SilverWolf32]

Also, the desktop app's window title bar on OS X is still light, even when using the dark theme. I'm not quite sure whether to put that here or somewhere else, since it's desktop-specific, but it's definitely noticeable, pretty much forcing me to use the client full screen. (The latest OS X has system-wide dark mode, and apps have to explicitly opt in to get dark-themed.)

[dkasak]

Username highlights on the dark theme look awful while unselected due to the brownish background colour:

It's a bit better when selected since it then changes to a grey shade:

[Mattwmaster58]

Also, the desktop app's window title bar on OS X is still light

This is also the case with Windows

[t3chguy]

When inactive yes, when active it matches the theme colour as expected.

[Mattwmaster58]

@t3chguy, huh, that's strange. Here's a screenshot with the window active:

I've never seen the title bar styled properly.

riot-web version: 1.5.12
olm version: 3.1.3

[t3chguy]

What does your explorer window look like in comparison?

[Mattwmaster58]

Dark - I have windows dark theme on. I have set 'follow system theme set' in riot web settings

[HelderFSFerreira]

I have the same issue as @Mattwmaster58 on windows 10 with dark mode enabled.

[MadLittleMods]

Are we good to close this? I count only 3 remaining unchecked tasks. Two of which need issues if they're still actually problems anyway. And I assume there has been a lot more iteration than linked here.

[turt2live]

Yea, I think if there's any remaining issues then independent ones would be best :)