Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin/Unpin Logic #3084

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Pin/Unpin Logic #3084

merged 6 commits into from
Jul 26, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 24, 2024

Requires an updated SDK containing the following PR: matrix-org/matrix-rust-sdk#3750

fixes #3058

Simulator.Screen.Recording.-.iPhone.15.-.2024-07-24.at.18.36.11.mp4

@Velin92 Velin92 requested a review from a team as a code owner July 24, 2024 16:50
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 24, 2024 16:50
@Velin92 Velin92 marked this pull request as draft July 24, 2024 16:51
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Jul 24, 2024
Copy link

github-actions bot commented Jul 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9278aa6

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@Velin92 Velin92 force-pushed the mauroromito/pin_unpin_logic branch from 3f4a151 to dc40f0d Compare July 25, 2024 12:18
@Velin92 Velin92 marked this pull request as ready for review July 26, 2024 14:14
@Velin92 Velin92 force-pushed the mauroromito/pin_unpin_logic branch from e74d79c to e920432 Compare July 26, 2024 14:14
@Velin92 Velin92 enabled auto-merge (squash) July 26, 2024 14:15
Copy link

sonarcloud bot commented Jul 26, 2024

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 45.87156% with 59 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (5a4d21a) to head (9278aa6).

Files Patch % Lines
...ne/TimelineController/RoomTimelineController.swift 0.00% 28 Missing ⚠️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 63.33% 11 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 62.50% 9 Missing ⚠️
...eens/RoomScreen/RoomScreenInteractionHandler.swift 0.00% 5 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 0.00% 3 Missing ⚠️
...View/ItemMenu/TimelineItemMenuActionProvider.swift 0.00% 2 Missing ⚠️
...mScreen/View/ItemMenu/TimelineItemMenuAction.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3084      +/-   ##
===========================================
- Coverage    77.92%   77.88%   -0.04%     
===========================================
  Files          703      703              
  Lines        54436    54510      +74     
===========================================
+ Hits         42421    42457      +36     
- Misses       12015    12053      +38     
Flag Coverage Δ
unittests 68.48% <45.87%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 disabled auto-merge July 26, 2024 18:40
@Velin92 Velin92 merged commit 0da2d49 into develop Jul 26, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/pin_unpin_logic branch July 26, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Pin/Unpin a message
2 participants