Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a potential crash when logging out. #3090

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix a potential crash when logging out. #3090

merged 1 commit into from
Jul 26, 2024

Conversation

pixlwave
Copy link
Member

There was something like a 30% chance that a logout would crash, we tracked it down to the use of self in the stopSync task.

@pixlwave pixlwave requested a review from a team as a code owner July 26, 2024 09:45
@pixlwave pixlwave requested review from stefanceriu and Velin92 and removed request for a team and stefanceriu July 26, 2024 09:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 850fa4c

@pixlwave pixlwave added the pr-bugfix for bug fix label Jul 26, 2024
@pixlwave pixlwave changed the title Fix a crash when the ClientProxy is freed. Fix a crash when the ClientProxy is freed (logout). Jul 26, 2024
@pixlwave pixlwave changed the title Fix a crash when the ClientProxy is freed (logout). Fix a crash when the ClientProxy is freed. Jul 26, 2024
@pixlwave pixlwave changed the title Fix a crash when the ClientProxy is freed. Fix a crash when logging out. Jul 26, 2024
@pixlwave pixlwave changed the title Fix a crash when logging out. Fix a potential crash when logging out. Jul 26, 2024
@pixlwave pixlwave enabled auto-merge (squash) July 26, 2024 09:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit 5a4d21a into develop Jul 26, 2024
8 checks passed
@pixlwave pixlwave deleted the doug/fix-logout branch July 26, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
pr-bugfix for bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @Velin92