Refactor TimelineItemSendInfo out of the styler. #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 7907171 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3100 +/- ##
===========================================
+ Coverage 77.83% 77.85% +0.01%
===========================================
Files 704 705 +1
Lines 54534 54584 +50
===========================================
+ Hits 42449 42498 +49
- Misses 12085 12086 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
force-pushed
the
doug/send-status
branch
from
3958cc8
to
9450429
Compare
stefanceriu
approved these changes
Jul 30, 2024
pixlwave
force-pushed
the
doug/send-status
branch
from
be29e86
to
7907171
Compare
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring in preparation to add encryption shields to messages in a similar way to send failures.
Last commit extends this with some (unexposed) encryption shield states.
(Technically they're on the wrong side, but will discuss with @amshakal tomorrow as it would be nice to have consistency for the status icon in this view)