Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SwiftPackageList to generate acknowledgements. #3117

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 5, 2024

This PR adds SwiftPackageList to the project and uses a git commit hook to automatically generate an Acknowledgements section for the app in the system Settings app.

Simulator Screen Recording - iPhone 15 Pro - 2024-08-05 at 17 59 42

@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Aug 5, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 5, 2024 17:01
@pixlwave pixlwave requested review from Velin92 and removed request for a team August 5, 2024 17:01
@pixlwave pixlwave added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against dc99109

@pixlwave
Copy link
Member Author

pixlwave commented Aug 5, 2024

I'm not massively enamoured by 8b86f6a but given they're sandboxed within the project anyway, maybe its fine 🤔

Copy link

github-actions bot commented Aug 5, 2024

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vyBmeE

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.45%. Comparing base (e667be0) to head (dc99109).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3117      +/-   ##
===========================================
+ Coverage    77.41%   77.45%   +0.03%     
===========================================
  Files          714      714              
  Lines        55334    55334              
===========================================
+ Hits         42837    42859      +22     
+ Misses       12497    12475      -22     
Flag Coverage Δ
unittests 68.31% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the doug/acknowledgements branch 2 times, most recently from 2b22d91 to 3aa337a Compare August 6, 2024 10:47
@pixlwave
Copy link
Member Author

pixlwave commented Aug 6, 2024

Alright, re-written it as a pre-commit git hook and we commit the Settings bundle.

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pixlwave pixlwave merged commit 0c9da2c into develop Aug 6, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/acknowledgements branch August 6, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants