Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned events banner loading state #3118

Merged
merged 12 commits into from
Aug 6, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 5, 2024

  • also updated the SDK
  • reversed the timeline for the banner
  • implemented a system to retry getting the timeline when networking is available
  • Improved the string building for polls and stickers
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-05.at.20.39.37.mp4

@Velin92 Velin92 requested a review from a team as a code owner August 5, 2024 17:18
@Velin92 Velin92 requested review from pixlwave and removed request for a team August 5, 2024 17:18
Copy link

github-actions bot commented Aug 5, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d373647

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 60.29412% with 81 lines in your changes missing coverage. Please review.

Project coverage is 77.69%. Comparing base (6a45ffc) to head (00a644b).

Files Patch % Lines
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 44.28% 39 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 67.60% 23 Missing ⚠️
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 7.14% 13 Missing ⚠️
...om/RoomSummary/RoomMessageEventStringBuilder.swift 0.00% 5 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3118      +/-   ##
===========================================
+ Coverage    77.47%   77.69%   +0.21%     
===========================================
  Files          714      714              
  Lines        55254    55390     +136     
===========================================
+ Hits         42809    43036     +227     
+ Misses       12445    12354      -91     
Flag Coverage Δ
unittests 68.27% <60.29%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@Velin92 Velin92 force-pushed the mauroromito/pinned_timeline_reversed branch from 4786499 to 6aaa032 Compare August 6, 2024 10:44
@Velin92 Velin92 enabled auto-merge (squash) August 6, 2024 10:44
@Velin92 Velin92 force-pushed the mauroromito/pinned_timeline_reversed branch from 32f7282 to d373647 Compare August 6, 2024 13:46
@Velin92 Velin92 disabled auto-merge August 6, 2024 13:46
@Velin92 Velin92 merged commit 08347e1 into develop Aug 6, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/pinned_timeline_reversed branch August 6, 2024 13:46
Copy link

sonarcloud bot commented Aug 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants