-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned events banner loading state #3118
Conversation
Generated by 🚫 Danger Swift against d373647 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3118 +/- ##
===========================================
+ Coverage 77.47% 77.69% +0.21%
===========================================
Files 714 714
Lines 55254 55390 +136
===========================================
+ Hits 42809 43036 +227
+ Misses 12445 12354 -91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👏
ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/TimelineView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Services/Room/RoomSummary/RoomMessageEventStringBuilder.swift
Outdated
Show resolved
Hide resolved
4786499
to
6aaa032
Compare
+ additional handling for polls and stickers string representation
is available
between the loading state and the loaded state not clean.
32f7282
to
d373647
Compare
Quality Gate passedIssues Measures |
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-05.at.20.39.37.mp4