Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a space between the version and build numbers on the Nightly icon #3124

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 6, 2024

Highly important PR - I've started using Nightly on macOS and the icon is bothering me 😅

@pixlwave pixlwave added the pr-misc for other changes label Aug 6, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 6, 2024 16:14
@pixlwave pixlwave requested review from Velin92 and removed request for a team August 6, 2024 16:14
Copy link

github-actions bot commented Aug 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 5c9f24e

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (a39a8f9) to head (5c9f24e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3124   +/-   ##
========================================
  Coverage    77.46%   77.46%           
========================================
  Files          715      715           
  Lines        55613    55613           
========================================
  Hits         43079    43079           
  Misses       12534    12534           
Flag Coverage Δ
unittests 68.42% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@stefanceriu stefanceriu merged commit 50c2b59 into develop Aug 6, 2024
12 checks passed
@stefanceriu stefanceriu deleted the doug/nightly-icon-label branch August 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants