Force the room list search text field to always be displayed #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanceriu
commented
Aug 7, 2024
•
stefanceriu
commented
- while looking into fixes we noticed that we can more easily break the layout when the search field is automatically hidden
pixlwave
approved these changes
Aug 7, 2024
Generated by 🚫 Danger Swift against 98c6a34 |
…e displayed - while looking into fixes we noticed that we can more easily break the layout when the search field is automatically hidden
stefanceriu
force-pushed
the
stefan/searchableTweaks
branch
from
ff4826b
to
98c6a34
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3127 +/- ##
===========================================
- Coverage 77.29% 77.23% -0.06%
===========================================
Files 715 715
Lines 55621 55641 +20
===========================================
- Hits 42990 42975 -15
- Misses 12631 12666 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stefanceriu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.