Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to the Pinned events timeline #3139

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 8, 2024

For now the pinned events timeline is empty and shows only the empty state

This PR has implemented the navigation to it, and also the behaviour in the room details screen to load the "Pinned events" row action.

Also this contains some minor refactor of the NetworkMonitor to include it in the AppMediator

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-08.at.13.17.18.mp4

@Velin92 Velin92 requested a review from a team as a code owner August 8, 2024 11:15
@Velin92 Velin92 requested review from pixlwave and removed request for a team August 8, 2024 11:15
Copy link

github-actions bot commented Aug 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 266b710

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Aug 8, 2024
@Velin92 Velin92 force-pushed the mauroromito/pinned_timeline branch from 23adf1a to 08d046f Compare August 8, 2024 11:18
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 57.65472% with 130 lines in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (534860b) to head (8cceb69).
Report is 5 commits behind head on develop.

Files Patch % Lines
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 26.00% 37 Missing ⚠️
...Screen/PinnedEventsTimelineScreenCoordinator.swift 0.00% 25 Missing ⚠️
...RoomDetailsScreen/RoomDetailsScreenViewModel.swift 52.17% 22 Missing ⚠️
...neScreen/PinnedEventsTimelineScreenViewModel.swift 26.66% 11 Missing ⚠️
...ns/RoomDetailsScreen/RoomDetailsScreenModels.swift 50.00% 9 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 6 Missing ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 63.63% 4 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 4 Missing ⚠️
ElementX/Sources/Application/AppMediator.swift 0.00% 2 Missing ⚠️
...melineScreen/View/PinnedEventsTimelineScreen.swift 94.44% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3139      +/-   ##
===========================================
- Coverage    77.27%   77.01%   -0.26%     
===========================================
  Files          715      719       +4     
  Lines        55596    55936     +340     
===========================================
+ Hits         42961    43081     +120     
- Misses       12635    12855     +220     
Flag Coverage Δ
unittests 68.33% <57.65%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

@Velin92 Velin92 force-pushed the mauroromito/pinned_timeline branch from 8a140ed to 266b710 Compare August 8, 2024 16:29
@Velin92 Velin92 merged commit ed7d3b0 into develop Aug 8, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/pinned_timeline branch August 8, 2024 16:29
Copy link

sonarcloud bot commented Aug 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants