-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigate to the Pinned events timeline #3139
Conversation
Generated by 🚫 Danger Swift against 266b710 |
23adf1a
to
08d046f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3139 +/- ##
===========================================
- Coverage 77.27% 77.01% -0.26%
===========================================
Files 715 719 +4
Lines 55596 55936 +340
===========================================
+ Hits 42961 43081 +120
- Misses 12635 12855 +220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😎
ElementX/Sources/Screens/PinnedEventsTimelineScreen/PinnedEventsTimelineScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/PinnedEventsTimelineScreen/View/PinnedEventsTimelineScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/PinnedEventsTimelineScreen/View/PinnedEventsTimelineScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomDetailsScreen/RoomDetailsScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomDetailsScreen/RoomDetailsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
PreviewTests/__Snapshots__/PreviewTests/test_roomDetailsScreen-iPhone-15-en-GB.Simple-Room.png
Outdated
Show resolved
Hide resolved
8a140ed
to
266b710
Compare
Quality Gate failedFailed conditions |
For now the pinned events timeline is empty and shows only the empty state
This PR has implemented the navigation to it, and also the behaviour in the room details screen to load the "Pinned events" row action.
Also this contains some minor refactor of the NetworkMonitor to include it in the AppMediator
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-08.at.13.17.18.mp4