Fixes #3126 - Prevent identity confirmation from blocking the user's progress after registering through OIDC #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…progress after registering through OIDC - happened because `hasRunIdentityConfirmationOnboarding` is false while the verification state is still `.unknown` - verification eventually changes to `.verified` but the flow coordinator doesn't catch up on it and blocks the flow
pixlwave
approved these changes
Aug 8, 2024
ElementX/Sources/FlowCoordinators/OnboardingFlowCoordinator.swift
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
Aug 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3141 +/- ##
===========================================
- Coverage 77.27% 77.10% -0.18%
===========================================
Files 715 715
Lines 55596 55735 +139
===========================================
+ Hits 42961 42973 +12
- Misses 12635 12762 +127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Generated by 🚫 Danger Swift against f67d43c |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasRunIdentityConfirmationOnboardingis false while the verification state is still.unknown.verifiedbut the flow coordinator doesn't catch up on it and blocks the flow