-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the copy for Mentions in notifications. #3142
Conversation
Generated by 🚫 Danger Swift against b1efff6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sensible to me 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3142 +/- ##
===========================================
- Coverage 77.68% 77.68% -0.01%
===========================================
Files 718 718
Lines 56655 56658 +3
===========================================
Hits 44014 44014
- Misses 12641 12644 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jmartinesp Did you look into this on Android? |
Not really, sorry. But I think it should be fairly easy to do what Amsha suggested and create a fake 'person' with the name |
No worries, in which case I'll rebase and merge this to close the iOS issue 👍 |
3e9a1e1
to
b1efff6
Compare
Quality Gate passedIssues Measures |
Fixes #2397. Keeping this draft until it is confirmed to work on Android too (with the notification summaries).