Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the copy for Mentions in notifications. #3142

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 8, 2024

Fixes #2397. Keeping this draft until it is confirmed to work on Android too (with the notification summaries).

Simulator Screenshot - iPhone 15 Pro - 2024-08-08 at 10 26 32

@pixlwave pixlwave requested a review from a team as a code owner August 8, 2024 14:29
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 8, 2024 14:29
@pixlwave pixlwave marked this pull request as draft August 8, 2024 14:29
Copy link

github-actions bot commented Aug 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against b1efff6

@pixlwave pixlwave changed the title Clarify the mention copy in notifications. Clarify the copy for Mentions in notifications. Aug 8, 2024
@pixlwave pixlwave added the pr-change for updates to an existing feature label Aug 8, 2024
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible to me 👍

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (304070e) to head (b1efff6).
Report is 1 commits behind head on develop.

Files Patch % Lines
NSE/Sources/NotificationContentBuilder.swift 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3142      +/-   ##
===========================================
- Coverage    77.68%   77.68%   -0.01%     
===========================================
  Files          718      718              
  Lines        56655    56658       +3     
===========================================
  Hits         44014    44014              
- Misses       12641    12644       +3     
Flag Coverage Δ
unittests 68.35% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave
Copy link
Member Author

@jmartinesp Did you look into this on Android?

@jmartinesp
Copy link
Member

@jmartinesp Did you look into this on Android?

Not really, sorry. But I think it should be fairly easy to do what Amsha suggested and create a fake 'person' with the name {person} mention or replied.

@pixlwave
Copy link
Member Author

No worries, in which case I'll rebase and merge this to close the iOS issue 👍

@pixlwave pixlwave force-pushed the doug/notification-mention-string branch from 3e9a1e1 to b1efff6 Compare August 22, 2024 11:27
@pixlwave pixlwave marked this pull request as ready for review August 22, 2024 11:27
Copy link

sonarcloud bot commented Aug 22, 2024

@pixlwave pixlwave enabled auto-merge (squash) August 22, 2024 11:32
@pixlwave pixlwave merged commit a1cb6bd into develop Aug 22, 2024
6 checks passed
@pixlwave pixlwave deleted the doug/notification-mention-string branch August 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"$foo mentioned you" notifications generally lie.
3 participants