Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt APIs available in SDK version 1.0.36 #3145

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-misc for other changes label Aug 9, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner August 9, 2024 10:15
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team August 9, 2024 10:15
Copy link

github-actions bot commented Aug 9, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 49d4069

Copy link

sonarcloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (b84c436) to head (49d4069).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 11 Missing ⚠️
...onResetScreen/EncryptionResetScreenViewModel.swift 0.00% 5 Missing ⚠️
...ResetScreen/EncryptionResetScreenCoordinator.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3145      +/-   ##
===========================================
- Coverage    77.37%   77.27%   -0.10%     
===========================================
  Files          719      719              
  Lines        55869    55935      +66     
===========================================
- Hits         43226    43225       -1     
- Misses       12643    12710      +67     
Flag Coverage Δ
unittests 68.35% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 13d2fa7 into develop Aug 9, 2024
12 checks passed
@stefanceriu stefanceriu deleted the stefan/sdkBump branch August 9, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants