Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SS proxy migration and waitlist screens #3154

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Aug 12, 2024

We must release this in EX apps only after the synapse release and global SSS availability on matrix.org.

@stefanceriu stefanceriu added the pr-misc for other changes label Aug 12, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner August 12, 2024 09:07
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team August 12, 2024 09:07
Copy link

github-actions bot commented Aug 12, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9baf5c1

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.21%. Comparing base (cce42a7) to head (9baf5c1).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ntication/LoginScreen/LoginScreenCoordinator.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3154      +/-   ##
===========================================
- Coverage    43.33%   43.21%   -0.12%     
===========================================
  Files          722      721       -1     
  Lines        58859    58706     -153     
===========================================
- Hits         25504    25369     -135     
+ Misses       33355    33337      -18     
Flag Coverage Δ
unittests 35.42% <80.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I thought we were waiting until we enable SSS to remove the migration screen?

@stefanceriu stefanceriu marked this pull request as draft August 12, 2024 09:52
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@stefanceriu stefanceriu marked this pull request as ready for review September 9, 2024 08:50
Copy link

sonarcloud bot commented Sep 9, 2024

@stefanceriu stefanceriu merged commit a0eafe2 into develop Sep 9, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/3146 branch September 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants