Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the server versions for matrix.org were used when signing in to a different server. #3155

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 12, 2024

As discussed here, we should use a new session directory every time we build a new client for authentication so this PR does exactly that.

The first commit is unrelated but removes an unused protocol from the project.

@pixlwave pixlwave requested a review from a team as a code owner August 12, 2024 10:04
@pixlwave pixlwave requested review from Velin92 and removed request for a team August 12, 2024 10:04
Copy link

github-actions bot commented Aug 12, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 372032b

@Velin92 Velin92 added the pr-bugfix for bug fix label Aug 12, 2024
@pixlwave pixlwave force-pushed the doug/change-servers-directory branch from 3fb97f9 to 372032b Compare August 12, 2024 10:16
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 15.55556% with 38 lines in your changes missing coverage. Please review.

Project coverage is 77.56%. Comparing base (13d2fa7) to head (372032b).
Report is 1 commits behind head on develop.

Files Patch % Lines
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 26 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3155      +/-   ##
===========================================
- Coverage    77.56%   77.56%   -0.01%     
===========================================
  Files          715      715              
  Lines        55821    55857      +36     
===========================================
+ Hits         43299    43325      +26     
- Misses       12522    12532      +10     
Flag Coverage Δ
unittests 68.32% <15.55%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 5e36811 into develop Aug 12, 2024
9 of 10 checks passed
@pixlwave pixlwave deleted the doug/change-servers-directory branch August 12, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants