generated from element-hq/.github
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoomScreenViewModel is now TimelineViewModel #3157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 8825cb9 |
Velin92
added
the
pr-wip
for anything that isn't ready to ship and will be enabled at a later date
label
Aug 12, 2024
pixlwave
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I'm looking forward to this - its going to be much neater :)
ElementX/Sources/Screens/HomeScreen/HomeScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/ComposerToolbar/ComposerToolbarViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/PinnedEventsTimelineScreen/View/PinnedEventsTimelineScreen.swift
Show resolved
Hide resolved
Velin92
force-pushed
the
mauroromito/reusable_timeline_2
branch
from
August 13, 2024 09:24
e389717
to
1e182c3
Compare
Velin92
force-pushed
the
mauroromito/reusable_timeline_2
branch
from
August 13, 2024 11:36
1e182c3
to
8825cb9
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step into separating the timeline behaviour from the generic room behaviour.
For now this is mostly a renaming, and some small signature and function changes (for example the draft is now handled directly by exposed functions from the composer through the coordinator).
The TimelineViewModel still does all the room screen work, but I created a view model and some models for it, in case we want to slowly migrate over time some functionalities from the TimelineViewModel into the new RoomScreenViewModel. ( For example the pinned banner handling could be migrated to it or the navigation to the details... and so on...)
I also added the TimelineViewModel to the PinnedEventsTimelineCoordinator, and is now possible to see the pinned events, even if actions are not yet handled and there are some errors being thrown by pagination
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-12.at.21.03.58.mp4