Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a danger check for PR titles that contain a "Fixes #1234" prefix. #3161

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 13, 2024

Specially made for @stefanceriu 😉

@pixlwave pixlwave requested a review from a team as a code owner August 13, 2024 11:12
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 13, 2024 11:12
@pixlwave pixlwave added the pr-misc for other changes label Aug 13, 2024
@stefanceriu
Copy link
Member

danger-swift failed.

Haha, nice, thank you! 😁

@pixlwave pixlwave force-pushed the doug/danger branch 2 times, most recently from 00d08f0 to d41f1e5 Compare August 13, 2024 11:22
@pixlwave pixlwave changed the title Fixes #1234 - Add a danger check for PR titles that contain a "Fixes #1234" prefix. Add a danger check for PR titles that contain a "Fixes #1234" prefix. Aug 13, 2024
Copy link

sonarcloud bot commented Aug 13, 2024

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.39%. Comparing base (2fa7934) to head (32cc3bd).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3161      +/-   ##
===========================================
+ Coverage    77.35%   77.39%   +0.03%     
===========================================
  Files          715      715              
  Lines        55847    55847              
===========================================
+ Hits         43202    43224      +22     
+ Misses       12645    12623      -22     
Flag Coverage Δ
unittests 68.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave added pr-misc for other changes and removed pr-misc for other changes labels Aug 13, 2024
@pixlwave pixlwave merged commit 1384a72 into develop Aug 13, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/danger branch August 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants