-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically try reloading failed images on network changes #3170
Conversation
Generated by 🚫 Danger Swift against 42d2f5a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3170 +/- ##
===========================================
- Coverage 77.33% 77.26% -0.07%
===========================================
Files 717 717
Lines 56141 56247 +106
===========================================
+ Hits 43415 43459 +44
- Misses 12726 12788 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ng images when connectivity is established again and use it for LoadableImages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this seems neat to me, let see what happens 😎
3dffc0b
to
088c0d0
Compare
Quality Gate failedFailed conditions |
This PR exposes a new mechanism in the ImageProvider that can hold off image loading resolution until the connectivity is re-established. It automatically handles cancelling tasks when views get deallocated and will bail out if the second attempt fails while on a reachable connection to avoid retrying indefinitely.
It also refactors the MediaProvider tests and moves towards a generated mock MediaLoader.