Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update #3172

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Translations update #3172

merged 1 commit into from
Aug 15, 2024

Conversation

RiotRobot
Copy link
Collaborator

  • Translations update

@RiotRobot RiotRobot requested a review from a team as a code owner August 15, 2024 16:34
@RiotRobot RiotRobot requested review from stefanceriu and removed request for a team August 15, 2024 16:34
@RiotRobot RiotRobot added the pr-i18n for translations label Aug 15, 2024
Copy link

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against b3e1c1d

Copy link

sonarcloud bot commented Aug 15, 2024

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.68%. Comparing base (13d2fa7) to head (b3e1c1d).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3172      +/-   ##
===========================================
- Coverage    77.56%   73.68%   -3.88%     
===========================================
  Files          715      770      +55     
  Lines        55821    61805    +5984     
===========================================
+ Hits         43299    45544    +2245     
- Misses       12522    16261    +3739     
Flag Coverage Δ
unittests 68.43% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the coverage drop is about these are only strings…

@pixlwave pixlwave merged commit 4f5b652 into develop Aug 15, 2024
11 of 12 checks passed
@pixlwave pixlwave deleted the translations/update branch August 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-i18n for translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants