Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a notification if its event has been redacted. #3191

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pixlwave
Copy link
Member

iOS equivalent of element-hq/element-x-android#3320

We can't mutate existing notifications on iOS so we simply remove it instead.

@pixlwave pixlwave requested a review from a team as a code owner August 22, 2024 11:23
@pixlwave pixlwave requested review from Velin92 and removed request for a team August 22, 2024 11:23
@pixlwave pixlwave added the pr-change for updates to an existing feature label Aug 22, 2024
@pixlwave pixlwave changed the title Remove delivered notifications if their event gets redacted. Remove notifications if their event gets redacted. Aug 22, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f84c596

@pixlwave pixlwave changed the title Remove notifications if their event gets redacted. Remove a notification if its event gets redacted. Aug 22, 2024
@pixlwave pixlwave changed the title Remove a notification if its event gets redacted. Remove a notification if its event has been redacted. Aug 22, 2024
Copy link

sonarcloud bot commented Aug 22, 2024

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.63%. Comparing base (304070e) to head (f84c596).
Report is 2 commits behind head on develop.

Files Patch % Lines
NSE/Sources/NotificationServiceExtension.swift 0.00% 30 Missing ⚠️
...urces/Other/Extensions/UNNotificationContent.swift 0.00% 9 Missing ⚠️
NSE/Sources/NotificationContentBuilder.swift 0.00% 4 Missing ⚠️
NSE/Sources/Other/UNNotificationRequest.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3191      +/-   ##
===========================================
- Coverage    77.68%   77.63%   -0.06%     
===========================================
  Files          718      718              
  Lines        56655    56692      +37     
===========================================
  Hits         44014    44014              
- Misses       12641    12678      +37     
Flag Coverage Δ
unittests 68.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit d54e08e into develop Aug 22, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/redact-notifications branch August 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants