Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the call URL input field in Developer Options #3192

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

pixlwave
Copy link
Member

There were 2 bugs:

  • The string was always set to "" when opening the screen instead of loading the current value.
  • Setting the string to "" wasn't setting the override setting back to nil.

@pixlwave pixlwave added the pr-misc for other changes label Aug 22, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 22, 2024 12:26
@pixlwave pixlwave requested review from Velin92 and removed request for a team August 22, 2024 12:26
Copy link

github-actions bot commented Aug 22, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 27ad2d4

Copy link

sonarcloud bot commented Aug 22, 2024

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.66%. Comparing base (d54e08e) to head (27ad2d4).
Report is 2 commits behind head on develop.

Files Patch % Lines
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3192      +/-   ##
===========================================
- Coverage    77.68%   77.66%   -0.02%     
===========================================
  Files          718      718              
  Lines        56695    56707      +12     
===========================================
- Hits         44041    44039       -2     
- Misses       12654    12668      +14     
Flag Coverage Δ
unittests 68.30% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 8c07397 into develop Aug 22, 2024
10 checks passed
@pixlwave pixlwave deleted the doug/element-call-fixes branch August 22, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants