Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture in Picture support for Calls (requires a supported widget deployment). #3204

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

pixlwave
Copy link
Member

Remove the feature flag on EC PiP support - this will now be driven by the web view canEnablePip API.

@pixlwave pixlwave added the pr-feature for a new feature label Aug 27, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 27, 2024 09:25
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 27, 2024 09:25
@pixlwave pixlwave changed the title Picture in Picture support for Calls (requires an up-to-date widget deployment). Picture in Picture support for Calls (required a supported widget deployment). Aug 27, 2024
@pixlwave pixlwave changed the title Picture in Picture support for Calls (required a supported widget deployment). Picture in Picture support for Calls (requires a supported widget deployment). Aug 27, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 093a587

Copy link

sonarcloud bot commented Aug 27, 2024

@pixlwave
Copy link
Member Author

Failing snapshots are unrelated to these changes.

@pixlwave pixlwave merged commit 61df1dd into develop Aug 27, 2024
7 of 8 checks passed
@pixlwave pixlwave deleted the doug/remove-pip-feature-flag branch August 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants