Update the client's request timeout to match the SDK's default. #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad tasks 🤦♂️ This new value isn't great either but there's a balance to be made.
pixlwave
changed the title
Generated by 🚫 Danger Swift against 3baf9b3 |
|
pixlwave
added
pr-bugfix
stefanceriu
approved these changes
Aug 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3205 +/- ##
========================================
Coverage 77.42% 77.42%
========================================
Files 722 722
Lines 57218 57218
========================================
+ Hits 44299 44301 +2
+ Misses 12919 12917 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-story: The
timeoutvalue sets the matching property on reqwest, however turns out this is the overall timeout and so if say a media download hasn't finished yet, it will be killed part way though. It seems like we should be setting the read timeout here, but until then, we're matching the default we had before in the SDK.This new value isn't great either but there's a balance to be made.