Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure reactions always go through the timeline controller. #3209

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 28, 2024

There was one use of the live timeline (the 5 default emojis in the action menu) but we should always do this on the activeTimeline.

@pixlwave pixlwave added the pr-bugfix for bug fix label Aug 28, 2024
@pixlwave pixlwave requested a review from a team as a code owner August 28, 2024 16:43
@pixlwave pixlwave requested review from stefanceriu and removed request for a team August 28, 2024 16:43
@pixlwave pixlwave changed the title Make sure reactions go through the timeline controller. Make sure reactions always go through the timeline controller. Aug 28, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f1bef40

Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (e439689) to head (f1bef40).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../Screens/Timeline/TimelineInteractionHandler.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3209      +/-   ##
===========================================
- Coverage    77.50%   77.40%   -0.11%     
===========================================
  Files          722      722              
  Lines        57218    57217       -1     
===========================================
- Hits         44345    44287      -58     
- Misses       12873    12930      +57     
Flag Coverage Δ
unittests 68.24% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 02f868c into develop Aug 29, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/toggle-reaction branch August 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants