Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a logout button on the identity confirmation screen #3212

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu added the pr-feature for a new feature label Aug 29, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner August 29, 2024 12:06
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team August 29, 2024 12:06
Copy link

github-actions bot commented Aug 29, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ca2a84f

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 24 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (904045f) to head (ca2a84f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../FlowCoordinators/UserSessionFlowCoordinator.swift 20.00% 16 Missing ⚠️
...s/FlowCoordinators/OnboardingFlowCoordinator.swift 66.66% 2 Missing ⚠️
...Screen/IdentityConfirmationScreenCoordinator.swift 0.00% 2 Missing ⚠️
...onScreen/IdentityConfirmationScreenViewModel.swift 0.00% 2 Missing ⚠️
...mationScreen/View/IdentityConfirmationScreen.swift 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3212      +/-   ##
===========================================
- Coverage    77.12%   77.05%   -0.08%     
===========================================
  Files          723      723              
  Lines        57256    57282      +26     
===========================================
- Hits         44158    44136      -22     
- Misses       13098    13146      +48     
Flag Coverage Δ
unittests 68.19% <38.46%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanceriu stefanceriu force-pushed the stefan/identityConfirmationKeyReset branch from 7831868 to ca2a84f Compare August 30, 2024 12:05
@stefanceriu stefanceriu merged commit 302df18 into develop Aug 30, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/identityConfirmationKeyReset branch August 30, 2024 12:07
Copy link

sonarcloud bot commented Aug 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants