Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require acknowledgement to send to verified users who have unsigned devices or have changed their identity. #3215

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 30, 2024

This PR makes the following changes:

  • Build clients with the requirements to fail when sending to once verified users who aren't (fully) verified any more
  • Show a description of the send failures for verified users in the TimelineItemMenu
  • Add a new sheet to resolve failures for verified users by tapping on the description above, or by tapping on the failure in the timeline.
  • If there is more than one user ID in the failure, the sheet iterates through them 1 by 1, resolving each one and then dismissing itself at the end.

Closes #3159.
Closes #3160.

@pixlwave pixlwave changed the base branch from develop to doug/sss-discovery August 30, 2024 09:37
Copy link

github-actions bot commented Aug 30, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 87b5d16

Base automatically changed from doug/sss-discovery to develop August 30, 2024 11:45
@pixlwave pixlwave changed the title Verified user send failures Require acknowledgement to send to verified users who have unsigned devices or have changed their identity. Sep 1, 2024
@pixlwave pixlwave added the pr-change for updates to an existing feature label Sep 1, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@element-hq element-hq deleted a comment from CLAassistant Sep 9, 2024
@element-hq element-hq deleted a comment from CLAassistant Sep 9, 2024
@pixlwave pixlwave marked this pull request as ready for review September 9, 2024 16:51
@pixlwave pixlwave requested a review from a team as a code owner September 9, 2024 16:51
@pixlwave pixlwave requested review from Velin92 and stefanceriu and removed request for a team and Velin92 September 9, 2024 16:51
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veery nice! 👌

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 48.69281% with 157 lines in your changes missing coverage. Please review.

Project coverage is 43.87%. Comparing base (1a3378f) to head (87b5d16).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...eVerifiedUserSendFailureScreenViewModelTests.swift 0.00% 58 Missing ⚠️
...esolveVerifiedUserSendFailureScreenViewModel.swift 40.00% 33 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 22 Missing ⚠️
...olveVerifiedUserSendFailureScreenCoordinator.swift 0.00% 19 Missing ⚠️
...en/View/ResolveVerifiedUserSendFailureScreen.swift 84.00% 8 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 0.00% 4 Missing ⚠️
...eens/Timeline/View/ItemMenu/TimelineItemMenu.swift 91.11% 4 Missing ⚠️
...Screen/PinnedEventsTimelineScreenCoordinator.swift 0.00% 3 Missing ⚠️
...X/Sources/Screens/Timeline/TimelineViewModel.swift 0.00% 3 Missing ⚠️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3215      +/-   ##
===========================================
- Coverage    43.87%   43.87%   -0.01%     
===========================================
  Files          723      728       +5     
  Lines        59406    59677     +271     
===========================================
+ Hits         26063    26181     +118     
- Misses       33343    33496     +153     
Flag Coverage Δ
unittests 36.38% <48.69%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit cc4942f into develop Sep 10, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/identity-send-failures branch September 10, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
3 participants