Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Prefire with a very similar but simpler and more direct approach #3232

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

stefanceriu
Copy link
Member

I think we still need to:

  • Get rid of Prefire in Compound?
  • Maybe replace the Snapshotting.swift extensions
  • Clean up the template?

@stefanceriu stefanceriu requested a review from a team as a code owner September 4, 2024 15:02
Copy link

github-actions bot commented Sep 4, 2024

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1ebf8bc

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 672 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (3b0f02d) to head (b7f6829).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
PreviewTests/Sources/PreviewTests.swift 0.00% 628 Missing ⚠️
...ementX/Sources/Other/Extensions/Snapshotting.swift 0.00% 10 Missing ⚠️
...mMemberListScreen/View/RoomMembersListScreen.swift 0.00% 5 Missing ⚠️
...s/Screens/JoinRoomScreen/View/JoinRoomScreen.swift 0.00% 4 Missing ⚠️
...ens/RoomDetailsScreen/View/RoomDetailsScreen.swift 0.00% 3 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 0.00% 3 Missing ⚠️
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 0.00% 2 Missing ⚠️
...DetailsEditScreen/View/RoomDetailsEditScreen.swift 0.00% 2 Missing ⚠️
...Screen/View/RoomMembersListManageMemberSheet.swift 0.00% 2 Missing ⚠️
...llsHistoryScreen/View/RoomPollsHistoryScreen.swift 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3232      +/-   ##
===========================================
- Coverage    54.43%   53.78%   -0.66%     
===========================================
  Files          723      725       +2     
  Lines        53926    54565     +639     
===========================================
- Hits         29355    29348       -7     
- Misses       24571    25217     +646     
Flag Coverage Δ
unittests 39.68% <0.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@stefanceriu stefanceriu added the pr-build for changes related to build, tools, CI/CD label Sep 6, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 👏

.gitattributes Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking a question right at the start of the review so I haven't seen any code, but how come these moved?

ElementX/Sources/Other/Extensions/Snapshotting.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/TestablePreview.swift Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really nice now if we could separate out the generated code from assertSnapshots(matching: preview) and everything it calls.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do that as the next step, separating everything in a differnet repo to be used by compound as well

PreviewTests/SupportingFiles/target.yml Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 9, 2024

@stefanceriu stefanceriu merged commit 2f6fea2 into develop Sep 9, 2024
6 of 7 checks passed
@stefanceriu stefanceriu deleted the stefan/prefireReplacement branch September 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants