Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay setting up subscriptions until the RoomListService is running in order to avoid cancelling in flight initial sync requests #3233

Merged

Conversation

stefanceriu
Copy link
Member

No description provided.

…n order to avoid cancelling in flight initial sync requests
@stefanceriu stefanceriu added the pr-change for updates to an existing feature label Sep 5, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 5, 2024 12:07
Copy link

github-actions bot commented Sep 5, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 2716d46

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (dc85cb1) to head (2716d46).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3233       +/-   ##
============================================
+ Coverage    45.51%   67.72%   +22.21%     
============================================
  Files          723      723               
  Lines        53927    53934        +7     
============================================
+ Hits         24543    36528    +11985     
+ Misses       29384    17406    -11978     
Flag Coverage Δ
unittests 68.57% <0.00%> (+33.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu force-pushed the stefan/delaySubscriptionsUntilRoomListServiceRunning branch from ead2e29 to 2716d46 Compare September 5, 2024 14:25
@stefanceriu stefanceriu merged commit b43797f into develop Sep 5, 2024
16 checks passed
@stefanceriu stefanceriu deleted the stefan/delaySubscriptionsUntilRoomListServiceRunning branch September 5, 2024 14:26
Copy link

sonarcloud bot commented Sep 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant