Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow voice message playback in the background #3236

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Sep 6, 2024

  • inform other audio sessions on deactivation
  • let CallKit handle the audioSession for ElementCall
  • add support for showing media playback controls on the lock screen (mostly copied from my original Riot implementation here

- inform other audio sessions on deactivation
- let CallKit handle the audioSession for ElementCall
@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 6, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 6, 2024 07:46
Copy link

github-actions bot commented Sep 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d245956

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 20.16807% with 95 lines in your changes missing coverage. Please review.

Project coverage is 45.08%. Comparing base (0f3b33c) to head (d245956).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...urces/Services/Audio/Player/AudioPlayerState.swift 5.71% 66 Missing ⚠️
...tX/Sources/Services/Audio/Player/AudioPlayer.swift 0.00% 10 Missing ⚠️
.../Timeline/TimelineItems/RoomTimelineItemView.swift 0.00% 3 Missing ⚠️
UnitTests/Sources/AudioPlayerStateTests.swift 0.00% 3 Missing ⚠️
...tTests/Sources/ComposerToolbarViewModelTests.swift 0.00% 3 Missing ⚠️
UnitTests/Sources/MediaPlayerProviderTests.swift 0.00% 3 Missing ⚠️
...s/FlowCoordinators/OnboardingFlowCoordinator.swift 0.00% 1 Missing ⚠️
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 1 Missing ⚠️
...omposerToolbar/View/MessageComposerTextField.swift 75.00% 1 Missing ⚠️
.../Screens/Timeline/TimelineInteractionHandler.swift 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3236      +/-   ##
===========================================
- Coverage    45.11%   45.08%   -0.04%     
===========================================
  Files          722      722              
  Lines        53901    53963      +62     
===========================================
+ Hits         24320    24330      +10     
- Misses       29581    29633      +52     
Flag Coverage Δ
unittests 35.56% <20.16%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu changed the title Fixes #3197 - Allow voice message playback in the background Allow voice message playback in the background Sep 6, 2024
@manuroe manuroe added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EiTpnk

Copy link

sonarcloud bot commented Sep 6, 2024

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stefanceriu stefanceriu merged commit a4166de into develop Sep 9, 2024
11 checks passed
@stefanceriu stefanceriu deleted the stefan/3197 branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants