Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Tweaks #3242

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Pin Tweaks #3242

merged 1 commit into from
Sep 9, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 9, 2024

Pun intended

  • Remove delete action from the pinned context menu
  • Move Pin/Unpin action below Edit
  • Timeline in pinned modes should NOT display the typing notifications
  • Remove the 1 of 1 copy when there is only 1 message in the banner
  • Filter reactions in the pinned timeline client side

@Velin92 Velin92 requested a review from a team as a code owner September 9, 2024 15:20
@Velin92 Velin92 requested review from pixlwave and removed request for a team September 9, 2024 15:20
Copy link

github-actions bot commented Sep 9, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f1d7d7d

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

Copy link

sonarcloud bot commented Sep 9, 2024

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (d88440d) to head (f1d7d7d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...View/ItemMenu/TimelineItemMenuActionProvider.swift 0.00% 2 Missing ⚠️
...imeline/View/ItemMenu/TimelineItemMenuAction.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3242   +/-   ##
========================================
  Coverage    43.75%   43.75%           
========================================
  Files          723      723           
  Lines        59402    59406    +4     
========================================
+ Hits         25990    25996    +6     
+ Misses       33412    33410    -2     
Flag Coverage Δ
unittests 36.33% <81.25%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 1a3378f into develop Sep 9, 2024
13 checks passed
@Velin92 Velin92 deleted the mauroromito/pin_tweaks branch September 9, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants