Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure introspections are used on iOS 18. #3248

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 10, 2024

Requires element-hq/compound-ios#104 (and an update to Compound).

Fixes #3244.

Copy link

github-actions bot commented Sep 10, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 06c4b10

@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 10, 2024
@pixlwave pixlwave changed the title Add iOS 18 to the Introspect supported versions. Make sure introspections are used on iOS 18. Sep 10, 2024
@pixlwave pixlwave marked this pull request as ready for review September 10, 2024 10:44
@pixlwave pixlwave requested a review from a team as a code owner September 10, 2024 10:44
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 10, 2024 10:44
Copy link

sonarcloud bot commented Sep 10, 2024

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (cc4942f) to head (06c4b10).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3248      +/-   ##
===========================================
- Coverage    71.05%   71.05%   -0.01%     
===========================================
  Files          734      734              
  Lines        65134    65131       -3     
===========================================
- Hits         46282    46279       -3     
  Misses       18852    18852              
Flag Coverage Δ
unittests 68.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 5394523 into develop Sep 10, 2024
11 checks passed
@pixlwave pixlwave deleted the doug/introspect branch September 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 18 - Can't log in to OIDC server
2 participants