Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a banner that offers the user to transition to native sliding sync #3252

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Sep 10, 2024

This PR introduces the following logic to support migrating users to native sliding sync

  • if the user is logged in and using native SS then perfect, nothing to do
  • if using a proxy then:
    • if native is available as advertised through /versions a banner will be shown to prompt logout
    • if the proxy is no longer available as advertised through .well-known then force logout

Screenshot 2024-09-10 at 16 59 02

Fixes #3258

@stefanceriu stefanceriu requested a review from a team as a code owner September 10, 2024 12:28
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 10, 2024 12:28
Copy link

github-actions bot commented Sep 10, 2024

Fails
🚫 Please provide a complete title that can be used as a changelog entry.
Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 864a665

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu added the pr-feature for a new feature label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 60.48387% with 49 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (5394523) to head (864a665).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...urces/Screens/HomeScreen/HomeScreenViewModel.swift 32.72% 37 Missing ⚠️
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 4 Missing ⚠️
...ces/Screens/HomeScreen/HomeScreenCoordinator.swift 0.00% 4 Missing ⚠️
...en/View/HomeScreenSlidingSyncMigrationBanner.swift 93.75% 3 Missing ⚠️
...es/Screens/HomeScreen/View/HomeScreenContent.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3252      +/-   ##
===========================================
- Coverage    71.05%   71.04%   -0.02%     
===========================================
  Files          734      735       +1     
  Lines        65131    65234     +103     
===========================================
+ Hits         46279    46345      +66     
- Misses       18852    18889      +37     
Flag Coverage Δ
unittests 68.82% <60.48%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

sonarcloud bot commented Sep 11, 2024

@stefanceriu stefanceriu changed the title Fixes #2508 - Offer user to transition to SSS Add a banner that offers the user to transition to native sliding sync Sep 11, 2024
@stefanceriu stefanceriu merged commit bef8924 into develop Sep 11, 2024
10 of 11 checks passed
@stefanceriu stefanceriu deleted the stefan/ssMigrationNotice branch September 11, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer user to transition to SSS (iOS)
3 participants