-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a banner that offers the user to transition to native sliding sync #3252
Conversation
e38ba96
to
6b6835d
Compare
Generated by 🚫 Danger Swift against 864a665 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3252 +/- ##
===========================================
- Coverage 71.05% 71.04% -0.02%
===========================================
Files 734 735 +1
Lines 65131 65234 +103
===========================================
+ Hits 46279 46345 +66
- Misses 18852 18889 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
ElementX/Sources/Screens/HomeScreen/View/HomeScreenSlidingSyncMigrationBanner.swift
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
This PR introduces the following logic to support migrating users to native sliding sync
Fixes #3258