Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a pin icon #3257

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Added a pin icon #3257

merged 3 commits into from
Sep 11, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 10, 2024

Note: The preview tests require a delay, and the delay function to set them in the tests seems to be partially broken, it only applies the delay on iPad but not on iPhone tests.

Simulator Screenshot - iPhone 15 - 2024-09-10 at 18 47 02

@Velin92 Velin92 requested a review from a team as a code owner September 10, 2024 16:47
@Velin92 Velin92 requested review from stefanceriu and removed request for a team September 10, 2024 16:47
Copy link

github-actions bot commented Sep 10, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9f48e54

@stefanceriu stefanceriu added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Sep 11, 2024
@stefanceriu
Copy link
Member

The preview tests require a delay, and the delay function to set them in the tests seems to be partially broken, it only applies the delay on iPad but not on iPhone tests.

Not entirely sure what's wrong there but all the old tests were passing when the new snapshotting flows got merged. Let's tackle whatever it is separately from this PR

Copy link

sonarcloud bot commented Sep 11, 2024

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ship it! 🚀

@Velin92 Velin92 enabled auto-merge (squash) September 11, 2024 10:34
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (ff5b22c) to head (9f48e54).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3257      +/-   ##
===========================================
+ Coverage    77.46%   77.53%   +0.07%     
===========================================
  Files          725      725              
  Lines        58509    58652     +143     
===========================================
+ Hits         45323    45475     +152     
+ Misses       13186    13177       -9     
Flag Coverage Δ
unittests 68.92% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit ed67a29 into develop Sep 11, 2024
11 checks passed
@Velin92 Velin92 deleted the mauroromito/add_a_pin_icon branch September 11, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants