-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a pin icon #3257
Added a pin icon #3257
Conversation
0304a59
to
3745deb
Compare
Generated by 🚫 Danger Swift against 9f48e54 |
ElementX/Sources/Screens/Timeline/View/Style/TimelineItemBubbledStylerView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/Timeline/View/Style/TimelineItemBubbledStylerView.swift
Outdated
Show resolved
Hide resolved
Not entirely sure what's wrong there but all the old tests were passing when the new snapshotting flows got merged. Let's tackle whatever it is separately from this PR |
3745deb
to
9f48e54
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, ship it! 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3257 +/- ##
===========================================
+ Coverage 77.46% 77.53% +0.07%
===========================================
Files 725 725
Lines 58509 58652 +143
===========================================
+ Hits 45323 45475 +152
+ Misses 13186 13177 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Note: The preview tests require a delay, and the delay function to set them in the tests seems to be partially broken, it only applies the delay on iPad but not on iPhone tests.