Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the SessionDirectories type responsible for cleaning up data. #3261

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

pixlwave
Copy link
Member

Addresses the remaining comments from #3196

@pixlwave pixlwave requested a review from a team as a code owner September 11, 2024 12:01
Copy link

github-actions bot commented Sep 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 9f58df6

Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 90.38462% with 15 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (ff5b22c) to head (9f58df6).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ources/Services/UserSession/UserSessionStore.swift 0.00% 6 Missing ⚠️
...rces/Services/UserSession/SessionDirectories.swift 88.88% 4 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 2 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 1 Missing ⚠️
...Sources/Services/Keychain/KeychainController.swift 0.00% 1 Missing ⚠️
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3261      +/-   ##
===========================================
+ Coverage    77.46%   77.57%   +0.10%     
===========================================
  Files          725      725              
  Lines        58509    58811     +302     
===========================================
+ Hits         45323    45621     +298     
- Misses       13186    13190       +4     
Flag Coverage Δ
unittests 68.99% <90.38%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suuper nice cleanup! 👏

@pixlwave pixlwave added the pr-change for updates to an existing feature label Sep 11, 2024
@pixlwave pixlwave merged commit af3a6cc into develop Sep 11, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/session-directories branch September 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants