Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we don't reuse an old NSEUserSession after logging out and back in. #3273

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 12, 2024

There have been reports of users receiving blank notifications after upgrading to SSS. Turns out when the user logs out, the NSE isn't aware of this so attempts to re-use the same UserSession/Client from the old session.

This PR fixes it with an additional comparison at the start of the flow.

@pixlwave pixlwave requested a review from a team as a code owner September 12, 2024 09:03
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 12, 2024 09:03
@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 12, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 73e181a

Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (022cc59) to head (73e181a).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
NSE/Sources/NotificationServiceExtension.swift 0.00% 3 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3273      +/-   ##
===========================================
+ Coverage    77.51%   77.54%   +0.03%     
===========================================
  Files          725      725              
  Lines        58734    58738       +4     
===========================================
+ Hits         45527    45551      +24     
+ Misses       13207    13187      -20     
Flag Coverage Δ
unittests 69.00% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit d24214c into develop Sep 12, 2024
12 of 13 checks passed
@pixlwave pixlwave deleted the doug/sss-migration-notifications branch September 12, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants