Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop delaying subscriptions until after startup #3294

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

stefanceriu
Copy link
Member

Stop delaying subscriptions until after the room list service goes into running, that's not handled internally by the SDK

@stefanceriu stefanceriu added the pr-misc for other changes label Sep 17, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner September 17, 2024 14:35
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team September 17, 2024 14:35
Copy link

github-actions bot commented Sep 17, 2024

Fails
🚫

danger-swift failed.

Log

/var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/danger/99F4D5B5-CD04-47D3-B93F-65A522A18006/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/danger/99F4D5B5-CD04-47D3-B93F-65A522A18006/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against b56e398

Copy link

codecov bot commented Sep 17, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
824 1 823 0
View the top 1 failed tests by shortest run time
CompletionSuggestionServiceTests testUserSuggestionsWithEmptyText()
Stack Traces | 11.3s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

…to running, that's not handled internally by the SDK

- reverts b43797f
- relies on matrix-org/matrix-rust-sdk#3981
@Velin92 Velin92 force-pushed the stefan/roomListStateSubscriptionDelays branch from 829d18b to b56e398 Compare September 18, 2024 10:16
@Velin92 Velin92 enabled auto-merge (squash) September 18, 2024 10:16
@Velin92 Velin92 merged commit 9b6470d into develop Sep 18, 2024
4 of 5 checks passed
@Velin92 Velin92 deleted the stefan/roomListStateSubscriptionDelays branch September 18, 2024 10:16
Copy link

sonarcloud bot commented Sep 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants