Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow account deactivation when not using OIDC. #3295

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 17, 2024

Closes #3291 and adds account deactivation for accounts not using OIDC (controlled by Rust).

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-17.at.18.22.00.mp4

@pixlwave pixlwave requested a review from a team as a code owner September 17, 2024 15:40
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 17, 2024 15:40
Copy link

github-actions bot commented Sep 17, 2024

Fails
🚫

danger-swift failed.

Log

/var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/545A9BC6-817C-4F24-9B8C-C5AE21DAFFBE/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/545A9BC6-817C-4F24-9B8C-C5AE21DAFFBE/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against 418e290

@pixlwave pixlwave added the pr-change for updates to an existing feature label Sep 17, 2024
@pixlwave pixlwave changed the title Account deactivation. Allow account deactivation when not using OIDC. Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 74.03846% with 81 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@8660a22). Learn more about missing BASE report.
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...untScreen/DeactivateAccountScreenCoordinator.swift 0.00% 28 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 25 Missing ⚠️
...countScreen/DeactivateAccountScreenViewModel.swift 85.00% 9 Missing ⚠️
.../Settings/SettingsScreen/View/SettingsScreen.swift 57.14% 6 Missing ⚠️
...ources/DeactivateAccountScreenViewModelTests.swift 91.30% 6 Missing ⚠️
...teAccountScreen/View/DeactivateAccountScreen.swift 95.06% 4 Missing ⚠️
...ngs/SettingsScreen/SettingsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...tings/SettingsScreen/SettingsScreenViewModel.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3295   +/-   ##
==========================================
  Coverage           ?   77.36%           
==========================================
  Files              ?      735           
  Lines              ?    59433           
  Branches           ?        0           
==========================================
  Hits               ?    45982           
  Misses             ?    13451           
  Partials           ?        0           
Flag Coverage Δ
unittests 68.79% <74.03%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 17, 2024

@pixlwave pixlwave merged commit 5625e78 into develop Sep 17, 2024
9 of 11 checks passed
@pixlwave pixlwave deleted the doug/deactivate-account branch September 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Account deactivation
2 participants