Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the deactivate account screen. #3297

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

pixlwave
Copy link
Member

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-18.at.09.06.28.mp4

@pixlwave pixlwave requested a review from a team as a code owner September 18, 2024 08:11
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 18, 2024 08:11
@pixlwave pixlwave added the pr-misc for other changes label Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Fails
🚫

danger-swift failed.

Log

/var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/02155273-6E2B-4FEF-828A-A18631DDA04B/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/02155273-6E2B-4FEF-828A-A18631DDA04B/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against e693008

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (5625e78) to head (e693008).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3297   +/-   ##
========================================
  Coverage    77.27%   77.27%           
========================================
  Files          735      735           
  Lines        59433    59405   -28     
========================================
- Hits         45924    45906   -18     
+ Misses       13509    13499   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 18, 2024

@pixlwave pixlwave merged commit 5078f57 into develop Sep 18, 2024
9 of 11 checks passed
@pixlwave pixlwave deleted the doug/deactivation-presentation branch September 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants