Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await for room sync only for push notification invites #3307

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 19, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner September 19, 2024 13:23
@Velin92 Velin92 requested review from pixlwave and removed request for a team September 19, 2024 13:23
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@Velin92 Velin92 added the pr-bugfix for bug fix label Sep 19, 2024
@Velin92 Velin92 enabled auto-merge (squash) September 19, 2024 13:24
Copy link

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 56de3b2

Copy link

sonarcloud bot commented Sep 19, 2024

@Velin92 Velin92 merged commit 943f33b into develop Sep 19, 2024
9 checks passed
@Velin92 Velin92 deleted the mauroromito/fix_crash_during_awaiting_permalink branch September 19, 2024 13:42
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (5d678ab) to head (56de3b2).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3307      +/-   ##
===========================================
- Coverage    77.39%   77.38%   -0.01%     
===========================================
  Files          735      735              
  Lines        59436    59446      +10     
===========================================
+ Hits         45999    46002       +3     
- Misses       13437    13444       +7     
Flag Coverage Δ
unittests 68.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants