Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove message pinning FF #3318

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Remove message pinning FF #3318

merged 5 commits into from
Sep 30, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 23, 2024

let's merge this after the release, just for safety

@Velin92 Velin92 requested a review from a team as a code owner September 23, 2024 11:44
@Velin92 Velin92 requested review from pixlwave and removed request for a team September 23, 2024 11:44
@Velin92 Velin92 force-pushed the mauroromito/remove_pinning_ff branch from 9db4658 to 6faa575 Compare September 23, 2024 11:47
@Velin92 Velin92 added the pr-misc for other changes label Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 26b86b8

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

Copy link

codecov bot commented Sep 23, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
837 1 836 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_serverSelection()

Flake rate in main: 17.65% (Passed 14 times, Failed 3 times)

Stack Traces | 6.02s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-pseudo.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8937988 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Velin92 Velin92 force-pushed the mauroromito/remove_pinning_ff branch 2 times, most recently from d3c7d31 to 4a3277b Compare September 24, 2024 16:41
@Velin92 Velin92 enabled auto-merge (squash) September 24, 2024 16:42
@Velin92 Velin92 force-pushed the mauroromito/remove_pinning_ff branch from b94a024 to 4a3277b Compare September 30, 2024 10:22
@Velin92 Velin92 force-pushed the mauroromito/remove_pinning_ff branch from 4a3277b to 30faaf0 Compare September 30, 2024 10:24
Copy link

sonarcloud bot commented Sep 30, 2024

@Velin92 Velin92 merged commit 5f4c289 into develop Sep 30, 2024
11 checks passed
@Velin92 Velin92 deleted the mauroromito/remove_pinning_ff branch September 30, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants