Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log any failures when creating a call widget. #3339

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

pixlwave
Copy link
Member

I'm unable to use Element Call on my Nightly, and all I'm getting from the logs are

2024-09-27T09:39:50.559436Z ERROR elementx: Failed starting ElementCall Widget Driver with error: failedBuildingWidgetSettings | CallScreenViewModel.swift:163 | spans: root

Seems worth adding some additional logs here.

@pixlwave pixlwave added the pr-misc for other changes label Sep 27, 2024
@pixlwave pixlwave requested a review from a team as a code owner September 27, 2024 09:58
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 27, 2024 09:58
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e5dc200

Copy link

sonarcloud bot commented Sep 27, 2024

Copy link

codecov bot commented Sep 27, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
831 2 829 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 18.52% (Passed 66 times, Failed 15 times)

Stack Traces | 2.76s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9661255 is less than required 1.0
The lowest perceptual color precision 0.39999998 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 17.74% (Passed 102 times, Failed 22 times)

Stack Traces | 5.02s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.85461426 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit 605337b into develop Sep 27, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/call-logs branch September 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants