Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow focusing the different avatars making up a DM details cluster separately. #3341

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner September 27, 2024 11:16
@stefanceriu stefanceriu requested review from Velin92 and pixlwave and removed request for a team and Velin92 September 27, 2024 11:16
Copy link

github-actions bot commented Sep 27, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3aa3db6

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👌

Copy link

sonarcloud bot commented Sep 27, 2024

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
831 1 830 0
View the full list of 1 ❄️ flaky tests
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 25.86% (Passed 43 times, Failed 15 times)

Stack Traces | 12.2s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@stefanceriu stefanceriu merged commit 8a39940 into develop Sep 27, 2024
12 of 13 checks passed
@stefanceriu stefanceriu deleted the stefan/clusteredAvatarFocusing branch September 27, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants